Skip to content

Commit 760157e

Browse files
cailmdaleyclaude
andcommitted
felt: close cleanup-rhostats-jobscripts — deliverables complete, PRs open & green
Cold survey found zero remaining worker work. PR #736 (rho-stats removal) and #737 (candide scripts via apptainer) are both open, mergeable, and CI-green. The only remaining step is Martin's review, which is outside worker scope. Includes mechanical felt reindex churn. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 1f2ec52 commit 760157e

3 files changed

Lines changed: 29 additions & 29 deletions

File tree

.felt/dependabot-pr-triage/dependabot-pr-triage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ tags:
99
created-at: 2026-05-27T11:57:31.076323766+02:00
1010
closed-at: 2026-05-28T15:27:23.026Z
1111
outcome: All 6 PRs merged in-conversation (727 idna, 722 mistune, 724 gitpython, 720 jupyterlab + pyproject floor, 721 jupyter-server, 726 urllib3). 19 of 20 Dependabot alerts cleared. Last one (sqlitedict) dismissed as tolerable_risk; see [[shapepipe/sqlitedict-pickle-smell]]. Shuttle daemon didn't pick up the dispatch — root cause unknown, worth a separate look.
12+
tempered: true
1213
shuttle:
1314
enabled: true
1415
kind: oneshot
1516
project_dir: .
1617
agent: pi-gpt-5.4
17-
tempered: true
1818
---
1919

2020
## Why this exists

.felt/shapepipe/ci-green-on-develop/ci-green-on-develop.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ tags:
66
- ci
77
- constitution
88
created-at: 2026-05-29T12:34:31.800189806+02:00
9-
outcome: |-
10-
Conda removed from ShapePipe (#733 merged); develop is green including image publish. The container (slim Python 3.12 + apt + uv lockfile) is the single source of truth and CI runs pytest inside the dev image. ci-release.yml + doc-tests.yml + install_shapepipe + environment*.yml deleted; cd.yml builds docs in the image; install docs rewritten. The conda path had rotted into a multi-layer install failure — deleted rather than repaired, so the production astropy bug is moot. Remaining for a clean/tight/shared dev environment: (1) commit a shared .felt in the repo + curate which fibers go public; (2) make repo CLAUDE.md a real onboarding doc; (3) port cluster job scripts off conda; (4) #729 dependabot actions (recreating); (5) verify docs deploy on master; (6) strengthen the thin test suite (#708).
9+
outcome: 'Conda removed from ShapePipe (#733 merged); develop is green including image publish. The container (slim Python 3.12 + apt + uv lockfile) is the single source of truth and CI runs pytest inside the dev image. ci-release.yml + doc-tests.yml + install_shapepipe + environment*.yml deleted; cd.yml builds docs in the image; install docs rewritten. The conda path had rotted into a multi-layer install failure — deleted rather than repaired, so the production astropy bug is moot. Remaining for a clean/tight/shared dev environment: (1) commit a shared .felt in the repo + curate which fibers go public; (2) make repo CLAUDE.md a real onboarding doc; (3) port cluster job scripts off conda; (4) #729 dependabot actions (recreating); (5) verify docs deploy on master; (6) strengthen the thin test suite (#708).'
1110
---
1211

1312
## Desired State
@@ -127,4 +126,4 @@ and docs still deploy.
127126
- **Bare-metal cluster installs** — anyone who ran `install_shapepipe`
128127
directly (no container) loses it. Is the container/apptainer path
129128
sufficient for all cluster users, or does a documented non-container
130-
install need to survive in `installation.md`?
129+
install need to survive in `installation.md`?

.felt/shapepipe/cleanup-rhostats-jobscripts/cleanup-rhostats-jobscripts.md

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,36 @@
11
---
22
name: 'ShapePipe cleanup: remove obsolete rho-stats/stile; modernize candide job scripts'
3-
status: open
3+
status: closed
44
tags:
5-
- shapepipe
6-
- cleanup
7-
- constitution
5+
- shapepipe
6+
- cleanup
7+
- constitution
88
created-at: 2026-05-30T21:45:50.977369486+02:00
9+
closed-at: 2026-05-30T22:30:55.745891097+02:00
910
outcome: |-
10-
Done — two PRs open against develop, neither merged (Martin reviews). (1) PR
11-
#736: removed the in-ShapePipe PSF-systematics plotting path (mccd_plots_runner
12-
+ mccd_plot_utilities — the "rho statistics" were only a docstring promise, the
13-
code computed mean shapes + histograms, no treecorr/stile). Two sole-purpose
14-
configs deleted whole; six configs edited; docs updated to point PSF diagnostics
15-
at sp_validation/cosmo_val. In-image pytest 250 passed; CI green. (2) PR #737:
16-
candide_smp.sh / candide_mpi.sh now run via apptainer + the runtime image, no
17-
conda; SMP verified end-to-end on c03 (0 errors), MPI hybrid pattern written but
18-
needs a real allocation to verify (hangs on login node). Two scope findings:
19-
`stile` was already vestigial (zero refs anywhere — nothing to remove);
20-
`random_cat` was KEPT — it is a general LSS random-catalogue generator, not part
21-
of the rho-stats path, so deleting it would overreach what Martin flagged.
22-
canfar + ccin2p3 (cc_*.sh) scripts left untouched and noted in PR #737.
11+
Done — two PRs open against develop, neither merged (Martin reviews). (1) PR
12+
#736: removed the in-ShapePipe PSF-systematics plotting path (mccd_plots_runner
13+
+ mccd_plot_utilities — the "rho statistics" were only a docstring promise, the
14+
code computed mean shapes + histograms, no treecorr/stile). Two sole-purpose
15+
configs deleted whole; six configs edited; docs updated to point PSF diagnostics
16+
at sp_validation/cosmo_val. In-image pytest 250 passed; CI green. (2) PR #737:
17+
candide_smp.sh / candide_mpi.sh now run via apptainer + the runtime image, no
18+
conda; SMP verified end-to-end on c03 (0 errors), MPI hybrid pattern written but
19+
needs a real allocation to verify (hangs on login node). Two scope findings:
20+
`stile` was already vestigial (zero refs anywhere — nothing to remove);
21+
`random_cat` was KEPT — it is a general LSS random-catalogue generator, not part
22+
of the rho-stats path, so deleting it would overreach what Martin flagged.
23+
canfar + ccin2p3 (cc_*.sh) scripts left untouched and noted in PR #737.
2324
shuttle:
24-
enabled: true
25-
kind: oneshot
26-
host: c03
27-
project_dir: /automnt/n17data/cdaley/unions/shapepipe
28-
agent: claude-opus
29-
session:
30-
id: 56169c16-34d7-48e3-be19-f2248484c510
25+
enabled: true
26+
kind: oneshot
27+
host: c03
28+
project_dir: /automnt/n17data/cdaley/unions/shapepipe
3129
agent: claude-opus
32-
dispatched_at: 2026-05-30T20:28:23.663370727Z
30+
session:
31+
id: 7c02b521-17bd-44dc-ad10-709520d6d2bf
32+
agent: claude-opus
33+
dispatched_at: 2026-05-30T20:29:24.913621662Z
3334
---
3435

3536
## Desired State

0 commit comments

Comments
 (0)