refactor(make_cat): remove the dead galsim shape-serialization path#793
Open
cailmdaley wants to merge 1 commit into
Open
refactor(make_cat): remove the dead galsim shape-serialization path#793cailmdaley wants to merge 1 commit into
cailmdaley wants to merge 1 commit into
Conversation
No runner produces galsim shapes (there is no galsim_shapes_runner) and the dual-shape (len==5) input branch in make_cat_runner never fires — ngmix is the pipeline's only shape estimator, so the galsim serialization path was dead code. - delete SaveCatalogue._save_galsim_shapes and its "galsim" process mode (drops the now-orphaned cs_util.size import from make_cat) - make_cat_runner validates SHAPE_MEASUREMENT_TYPE against ngmix alone and drops the dead second-shape-catalogue branch; the list knob is kept as the extension point for a future estimator family - drop test_galsim_grammar_properties.py and the galsim cases from the frozen column-grammar examples in test_psf_grammar_properties.py - lose the galsim references in the make_cat docstring, the make_cat_mccd example config, and the cat_matched.param comment Carved out of #761 to keep that PR scoped to the reconvolved-PSF column grammar; the removal deletes a test #761 introduced. Closes #783 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dead galsim shape-serialization path from
make_cat. No runner produces galsim shapes (there is nogalsim_shapes_runner), and the dual-shape (len==5) input branch inmake_cat_runnernever fires — ngmix is the pipeline's only shape estimator.What changed
make_cat.py— deleteSaveCatalogue._save_galsim_shapes()and its"galsim"process mode; drop the now-orphanedcs_util.sizeimport.make_cat_runner.py—SHAPE_MEASUREMENT_TYPEnow validates againstngmixalone (raising otherwise); dead second-shape-catalogue (len==5) branch removed. The list knob is retained as the extension point for a future estimator family.test_galsim_grammar_properties.py; drop the galsim cases from the frozen column-grammar examples intest_psf_grammar_properties.py(now covering ngmix + HSM).make_catconfig-entry docstring, theconfig_make_cat_mccd.iniexample, and thecat_matched.paramcomment.Scope
Carved out of #761 (merged) per Axel's 2026-07-02 review to keep that PR scoped to the reconvolved-PSF column grammar; the removal deletes a test #761 introduced. The issue proposed retargeting to
ngmix_v2.0— but #741 has since mergedngmix_v2.0intodevelop(and deleted the branch), so this targetsdevelop. Cleanup, not a v2.0 correctness fix. Filed under the longer-term-improvements epic (#773).Tests
test_psf_grammar_properties.py+test_make_cat.py— 28 passed (run in the ngmix v2.0 dev container).Closes #783
🤖 Generated with Claude Code
— Claude (Opus) on behalf of Cail