Refactor: Move assign_attributes to Document class for consistency

- Move assign_attributes override from Persistence to Document class
- Ensures consistent behavior for both Document and NestedDocument
- Use Set for efficient unknown attribute lookup (performance optimization)
- Add require 'set' to base.rb
- Remove duplicate implementation from persistence.rb

This addresses code review feedback about consistency and performance.

Author: JulienBURNET-FAUCHE

lib/couchbase-orm/base.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true, encoding: ASCII-8BIT
 
 
+require 'set'
 require 'active_model'
 require 'active_support/hash_with_indifferent_access'
 require 'couchbase'
@@ -115,6 +116,29 @@ def attribute_writer_missing(name, value)
             end
         end
 
+        # Override assign_attributes to filter unknown attributes when raise_on_unknown_attributes is false
+        # This ensures consistent behavior across Document and NestedDocument
+        def assign_attributes(hash)
+            hash = hash.with_indifferent_access if hash.is_a?(Hash)
+
+            if self.class.raise_on_unknown_attributes
+                super(hash.except("type"))
+            else
+                # Filter unknown attributes
+                known_names = self.class.attribute_names
+                known_attrs = hash.slice(*known_names)
+
+                # Use a Set for efficient lookup of unknown keys
+                known_names_set = known_names.to_set
+                unknown_keys = hash.keys.reject { |k| known_names_set.include?(k) || k == "type" }
+
+                if unknown_keys.any?
+                    CouchbaseOrm.logger.warn "Ignoring unknown attribute(s) for #{self.class.name}: #{unknown_keys.join(', ')}"
+                end
+                super(known_attrs)
+            end
+        end
+
         protected
 
         def serialized_attributes

lib/couchbase-orm/persistence.rb

@@ -153,21 +153,8 @@ def update_attribute(name, value)
             changed? ? save(validate: false) : true
         end
 
-        def assign_attributes(hash)
-            hash = hash.with_indifferent_access if hash.is_a?(Hash)
-
-            # Filter unknown attributes if raise_on_unknown_attributes is false
-            if !self.class.raise_on_unknown_attributes
-                known_attrs = hash.slice(*self.class.attribute_names).except("type")
-                unknown_attrs = hash.keys - self.class.attribute_names - ["type"]
-                if unknown_attrs.any?
-                    CouchbaseOrm.logger.warn "Ignoring unknown attribute(s) for #{self.class.name}: #{unknown_attrs.join(', ')}"
-                end
-                super(known_attrs)
-            else
-                super(hash.except("type"))
-            end
-        end
+        # Note: assign_attributes is now handled in Document class (base.rb)
+        # to ensure consistent behavior across Document and NestedDocument
 
         # Updates the attributes of the model from the passed-in hash and saves the
         # record. If the object is invalid, the saving will fail and false will be returned.