Skip to content

➕ Add logger dependency to suppress Ruby 3.5.0 deprecation warning #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimpin merged 2 commits into from
Oct 27, 2025
Merged

➕ Add logger dependency to suppress Ruby 3.5.0 deprecation warning #21

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cb6774
Add logger dependency to suppress Ruby 3.5.0 deprecation warning
pimpin Oct 27, 2025
e89645c
Add version constraint to logger dependency
pimpin Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions couchbase-orm.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency 'couchbase', '>= 3.4.2'
gem.add_runtime_dependency 'radix', '~> 2.2' # converting numbers to and from any base
gem.add_runtime_dependency 'json-schema', '>= 3' # validating JSON against a schema
gem.add_runtime_dependency 'logger' # Required from Ruby 3.5.0+

@gemini-code-assist gemini-code-assist Bot Oct 27, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding logger as a dependency is correct, it's a good practice to specify a version constraint to ensure build reproducibility and prevent accidentally pulling in future versions with breaking changes. I'd suggest adding a pessimistic version constraint and aligning it with the other dependencies for consistency.

  gem.add_runtime_dependency     'logger',       '~> 1.6.0' # Required from Ruby 3.5.0+


gem.add_development_dependency 'rake', '~> 12.2'
gem.add_development_dependency 'rspec', '~> 3.7'
Expand Down