Skip to content

Fix N1QL injection in nested Hash attribute updates #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimpin merged 3 commits into from
Jun 26, 2026
Merged

Fix N1QL injection in nested Hash attribute updates #33

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd9d945
Fix N1QL injection in nested Hash attribute updates
pimpin Jun 24, 2026
6d3711c
Handle nil values in nested Hash attribute updates
pimpin Jun 24, 2026
d5bdce1
Add test coverage for nested Hash attribute quoting in update_all
pimpin Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/couchbase-orm/relation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def build_update(**cond)
end
if value.is_a?(Hash)
value.map do |k, v|
"#{key}.#{k} = #{v}"
"#{key}.#{k} = #{@model.quote(v) || 'NULL'}"
Comment thread
pimpin marked this conversation as resolved.
end.join(", ") + for_clause
else
"#{key} = #{@model.quote(value)}#{for_clause}"
Expand Down
Loading