Skip to content

Commit b3f5c32

Browse files
authored
Merge pull request #500 from Countly/hc_metrics_reverse
Hc metrics reverse
2 parents 4a90ab4 + f351e45 commit b3f5c32

3 files changed

Lines changed: 28 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
* Improved disk size calculation in crash reports.
33
* Added "setRequestTimeoutDuration(requestTimeoutDuration)" init config method configure request timeout in seconds.
44

5+
* Rolled back Health Check metric information to previous state.
56
* Mitigated an issue displaying Content on API level 35 and above.
67

78
## 25.4.3

sdk/src/main/java/ly/count/android/sdk/DeviceInfo.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -675,6 +675,32 @@ String getMetrics(@NonNull final Context context, @Nullable final Map<String, St
675675
return result;
676676
}
677677

678+
@NonNull
679+
String getMetricsHealthCheck(@NonNull final Context context, @Nullable final Map<String, String> metricOverride) {
680+
Map<String, Object> metrics = new ConcurrentHashMap<>();
681+
682+
String appVersion = mp.getAppVersion(context);
683+
684+
if (metricOverride != null) {
685+
if (metricOverride.containsKey("_app_version")) {
686+
appVersion = metricOverride.get("_app_version");
687+
}
688+
}
689+
690+
metrics.put("_app_version", appVersion);
691+
692+
String result = new JSONObject(metrics).toString();
693+
694+
try {
695+
result = java.net.URLEncoder.encode(result, "UTF-8");
696+
} catch (UnsupportedEncodingException ex) {
697+
// should never happen because Android guarantees UTF-8 support
698+
Countly.sharedInstance().L.e("[getMetrics] encode failed, [" + ex + "]");
699+
}
700+
701+
return result;
702+
}
703+
678704
/**
679705
* Returns a JSON object containing the device crash report
680706
*/

sdk/src/main/java/ly/count/android/sdk/ModuleHealthCheck.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ void sendHealthCheck() {
6262

6363
healthCheckSent = true;
6464

65-
String preparedMetrics = deviceInfo.getMetrics(_cly.context_, _cly.config_.metricOverride, L);
65+
String preparedMetrics = deviceInfo.getMetricsHealthCheck(_cly.context_, _cly.config_.metricOverride);
6666

6767
StringBuilder requestData = new StringBuilder(requestQueueProvider.prepareHealthCheckRequest(preparedMetrics));
6868
ConnectionProcessor cp = requestQueueProvider.createConnectionProcessor();

0 commit comments

Comments
 (0)