Skip to content

Commit 0769ed0

Browse files
authored
Merge pull request #7181 from Countly/remocon-status
[SER-2623] [remote-config] Fix searching for parameter in experiment variants
2 parents 46f30f7 + 46a456f commit 0769ed0

2 files changed

Lines changed: 16 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Fixes:
33
- [compliance-hub] Correctly merge user history on user merge
44
- [star-rating] Fix active status checkbox in drawer
55
- [star-rating] Fix consent fields in drawer
6+
- [remote-config] Fix searching for parameter in experiment variants
67

78
## Version 25.03.32
89
Fixes:

plugins/remote-config/frontend/public/javascripts/countly.models.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,21 @@
145145
parameters.forEach(function(parameter) {
146146
parameter.editable = true;
147147
resp.experiments.forEach(function(experiment) {
148-
if (experiment && experiment.status !== "completed" && experiment.variants && experiment.variants.length > 0 && experiment.variants[0].parameters.length && experiment.variants[0].parameters.length > 0 && experiment.variants[0].parameters[0].name === parameter.parameter_key) {
149-
parameter.abStatus = experiment.status;
150-
parameter.editable = false;
148+
if (experiment && experiment.status !== "completed" && experiment.variants && experiment.variants.length > 0) {
149+
var parameterInExperiment = experiment.variants.some(function(variant) {
150+
if (variant.parameters && variant.parameters.length > 0) {
151+
return variant.parameters.some(function(vParameter) {
152+
return vParameter.name === parameter.parameter_key;
153+
});
154+
}
155+
156+
return false;
157+
});
158+
159+
if (parameterInExperiment) {
160+
parameter.abStatus = experiment.status;
161+
parameter.editable = false;
162+
}
151163
}
152164
});
153165
if (parameter.expiry_dttm && parameter.expiry_dttm < Date.now()) {

0 commit comments

Comments
 (0)