Skip to content

Commit 07ce511

Browse files
authored
Merge pull request #7416 from Countly/QT-415
[QT-415] Added the data-test-id and update the some of the data-test-id value
2 parents 4ddec73 + 4803552 commit 07ce511

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

  • frontend/express/public/javascripts/countly/vue/components
  • ui-tests/cypress/support/elements

frontend/express/public/javascripts/countly/vue/components/form.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@
413413
mixins: [countlyVue.mixins.i18n],
414414
template: '<div class="cly-vue-form-field" :class="topClasses">\
415415
<div class="bu-is-flex bu-is-justify-content-space-between bu-mr-2" v-if="!inline || tooltip || label || optional">\
416-
<div :class="titleClasses" v-if="label" :data-test-id="testId + \'-header\'">{{label}}</div>\
416+
<div :class="titleClasses" v-if="label" v-if="label" :data-test-id="testId + \'-header-\' + label.replaceAll(\' \', \'-\').replaceAll(\'_\', \'-\').toLowerCase()">{{label}}</div>\
417417
<cly-tooltip-icon v-if="tooltip" :data-test-id="testId + \'-tooltip\'" class="bu-is-flex-grow-1 bu-ml-2" :tooltip="tooltip"></cly-tooltip-icon>\
418418
<div v-show="optional" class="text-small text-heading color-cool-gray-40">{{i18n("common.optional")}}</div>\
419419
</div>\

ui-tests/cypress/support/elements/dashboard/manage/alerts/alerts.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ export const alertsPageElements = {
2525
export const alertDrawerPageElements = {
2626
DRAWER_PAGE_TITLE: 'alert-drawer-header-title',
2727
DRAWER_CLOSE_BUTTON: 'alert-drawer-close-button',
28-
DRAWER_ALERT_NAME_LABEL: 'alert-name-header',
28+
DRAWER_ALERT_NAME_LABEL: 'alert-name-header-alert-name',
2929
DRAWER_ALERT_NAME_INPUT: 'alert-name-input',
30-
DRAWER_APPLICATION_LABEL: 'application-header',
30+
DRAWER_APPLICATION_LABEL: 'application-header-application',
3131
DRAWER_APPLICATION_SELECT: 'application-select',
3232

33-
DRAWER_DATA_TYPE_LABEL: 'data-type-header',
33+
DRAWER_DATA_TYPE_LABEL: 'data-type-header-data-type',
3434
DRAWER_DATA_TYPE_SELECT: 'data-type-select',
3535

3636
DRAWER_SUB_TYPE_LABEL: 'data-sub-type-header',

ui-tests/cypress/support/elements/onboarding/initialSetup.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export default {
22
//Common elements
33
LOGO: 'countly-logo',
44
PAGE_TITLE: 'initial-setup-title',
5-
SELECT_APP_TYPE_LABEL: 'select-application-type-form-header',
5+
SELECT_APP_TYPE_LABEL: 'select-application-type-form-header-select-your-application-type',
66
APP_TYPE_MOBILE_RADIO_BUTTON: 'initial-setup-mobile-el-radio-wrapper',
77
APP_TYPE_MOBILE_RADIO_BUTTON_ICON: 'initial-setup-mobile-icon',
88
APP_TYPE_MOBILE_RADIO_BUTTON_LABEL: 'initial-setup-mobile-el-radio-label',
@@ -12,18 +12,18 @@ export default {
1212
APP_TYPE_DESKTOP_RADIO_BUTTON: 'initial-setup-desktop-el-radio-wrapper',
1313
APP_TYPE_DESKTOP_RADIO_BUTTON_ICON: 'initial-setup-desktop-icon',
1414
APP_TYPE_DESKTOP_RADIO_BUTTON_LABEL: 'initial-setup-desktop-el-radio-label',
15-
SELECT_TIMEZONE_LABEL: 'select-timezone-form-header',
15+
SELECT_TIMEZONE_LABEL: 'select-timezone-form-header-select-your-time-zone',
1616
SELECT_TIMEZONE_TOOLTIP: 'select-timezone-form-tooltip',
1717
SELECT_TIMEZONE_COMBOBOX: 'select-timezone-dropdown',
1818
SELECT_TIMEZONE_SEARCH_INPUT: 'select-timezone-dropdown-search-box',
1919
CONTINUE_SUBMIT_BUTTON: 'continue-submit-button',
2020

2121
//"Own App" Elements
22-
APPLICATION_NAME_LABEL: 'application-name-header',
22+
APPLICATION_NAME_LABEL: 'application-name-header-application-name',
2323
PAGE_SUB_TITLE: 'initial-setup-sub-title',
2424
APPLICATION_NAME_INPUT: 'app-name-input',
2525
APPLICATION_NAME_ERROR: 'app-name-error',
26-
APPLICATION_KEY_LABEL: 'application-key-header',
26+
APPLICATION_KEY_LABEL: 'application-key-header-app-key',
2727
APPLICATION_KEY_TOOLTIP: 'application-key-tooltip',
2828
APPLICATION_KEY_INPUT: 'app-key-input',
2929
APPLICATION_KEY_ERROR: 'app-key-error',

0 commit comments

Comments
 (0)