Skip to content

Commit c112fb9

Browse files
authored
Merge pull request #6269 from Countly/master-fe-fixes
[SER-2432] Master fe fixes
2 parents 2f18ed7 + 412b671 commit c112fb9

File tree

4 files changed

+23
-5
lines changed

4 files changed

+23
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,17 @@ Enterprise Features:
66
Fixes:
77
- [core] Unifying alphabetical order for dropdowns with dashboard apps
88
- [hooks] Added null check for incoming data
9+
- [core] Fix auto refresh frontend component
10+
- [times-of-day] Fix chart component
11+
- [push] Fix external drawer initialization
912

1013
Enterprise Fixes:
1114
- [content] Asset URL was wrongly constructed when user switches between apps
1215
- [ab-testing] Updates
1316
- Do not wait for result calculation when requesting experiments
1417
- Do not calculate result for completed experiments
1518
- [drill] [license] Shorten warning period from 14 days to 3 days
19+
- [license] Fix chart legend
1620

1721
Dependencies:
1822
- Bump eslint-plugin-vue from 9.33.0 to 10.1.0

frontend/express/public/javascripts/countly/vue/components/helpers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1442,7 +1442,7 @@
14421442
<el-button @click='stopAutoRefresh()'><i class='bu-ml-2 fa fa-stop-circle' :data-test-id='testId + \"-auto-refresh-toggle-button\"'></i> {{i18n('auto-refresh.stop')}}\
14431443
</el-button>\
14441444
</div>\
1445-
<div v-else-if='!autoRefresh' class='bu-level-item'>\
1445+
<div class='bu-level-item' :class=\"{ 'bu-is-hidden': autoRefresh }\">\
14461446
<el-switch v-model='autoRefresh' :test-id='testId + \"-auto-refresh-toggle\"'>\
14471447
</el-switch>\
14481448
<span class='cly-vue-auto-refresh-toggle__refresh--disabled' :data-test-id='testId + \"-auto-refresh-toggle-disabled-label\"'>{{i18n('auto-refresh.enable')}}</span>\

plugins/push/frontend/public/javascripts/countly.views.js

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,21 @@
731731
}
732732
this.updatePlatformsBasedOnAppConfig();
733733
this.estimateIfNecessary();
734-
this.setEnabledUsers(this.$store.state.countlyPushNotificationDashboard.enabledUsers);
734+
735+
if (this.$store.state.countlyPushNotificationDashboard) {
736+
this.setEnabledUsers(this.$store.state.countlyPushNotificationDashboard.enabledUsers);
737+
}
738+
else {
739+
var self = this;
740+
741+
countlyPushNotification.service.fetchDashboard()
742+
.then(function(response) {
743+
self.setEnabledUsers(response.enabledUsers);
744+
})
745+
.catch(function(error) {
746+
console.error(error);
747+
});
748+
}
735749
},
736750
addButton: function() {
737751
this.pushNotificationUnderEdit.message[this.activeLocalization].buttons.push({label: "", url: ""});
@@ -2906,4 +2920,4 @@
29062920
app.configurationsView.registerLabel("push.proxyport", "push-notification.proxy-port");
29072921
app.configurationsView.registerLabel("push.proxyuser", "push-notification.proxy-user");
29082922
}
2909-
}());
2923+
}());

plugins/times-of-day/frontend/public/javascripts/countly.views.component.common.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
var MAX_SYMBOL_VALUE = 20;
55

66
countlyTimesOfDayComponent.ScatterChart = countlyVue.views.create({
7-
template: '<cly-chart-generic v-bind="$attrs" :option="timesOfDayOptions" v-loading="isLoading"></cly-chart-generic>',
7+
template: '<cly-chart-generic v-bind="$attrs" :option="timesOfDayOptions"></cly-chart-generic>',
88
mixins: [countlyVue.mixins.commonFormatters],
99
props: {
1010
maxSeriesValue: {
@@ -116,4 +116,4 @@
116116
}
117117
});
118118

119-
}(window.countlyTimesOfDayComponent = window.countlyTimesOfDayComponent || {}));
119+
}(window.countlyTimesOfDayComponent = window.countlyTimesOfDayComponent || {}));

0 commit comments

Comments
 (0)