Skip to content

[experimental] add SSL support for HTTP server configuration#6295

Merged
ar2rsawseen merged 5 commits intomasterfrom
feat/ssl-support
Jun 19, 2025
Merged

[experimental] add SSL support for HTTP server configuration#6295
ar2rsawseen merged 5 commits intomasterfrom
feat/ssl-support

Conversation

@kanwarujjaval
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds experimental SSL support for both the HTTP and API server configurations. The changes include new SSL configuration options, updates to the server setup logic to conditionally use HTTPS, and corresponding updates in configuration sample files.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
frontend/express/config.sample.js Added SSL configuration options for the Express web server.
frontend/express/app.js Updated server initialization to support SSL with HTTPS server.
api/config.sample.js Added SSL configuration options for the API server.
api/api.js Updated API server initialization to support SSL and HTTPS server.
Comments suppressed due to low confidence (1)

frontend/express/app.js:1944

  • The 'fs' module is used to read SSL files but is not imported in this file. Please add const fs = require('fs'); at the top to avoid runtime errors when SSL is enabled.
key: fs.readFileSync(countlyConfig.web.ssl.key),

@ar2rsawseen ar2rsawseen merged commit ed4638a into master Jun 19, 2025
10 checks passed
@widatama widatama deleted the feat/ssl-support branch July 21, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants