feat(MrqGenerationService): shuffle options when generating for the first time

Author: adi-herwana-nus

app/services/course/assessment/question/mrq_generation_service.rb

@@ -57,7 +57,7 @@ def generate_questions
         }
       }
     ).completion
-    parse_llm_response(response)
+    shuffle_output_options!(parse_llm_response(response))
   end
 
   private
@@ -66,13 +66,15 @@ def generate_questions
   # @return [Array<Hash>] Array of messages formatted for the LLM chat
   def build_messages
     system_prompt, user_prompt = select_prompts
+    source_question_options = @source_question_data&.dig('options') || []
+    @shuffle_options = true if source_question_options.empty?
     formatted_system_prompt = system_prompt.format
     formatted_user_prompt = user_prompt.format(
       custom_prompt: @custom_prompt,
       number_of_questions: @number_of_questions,
       source_question_title: @source_question_data&.dig('title') || '',
       source_question_description: @source_question_data&.dig('description') || '',
-      source_question_options: format_source_options(@source_question_data&.dig('options') || [])
+      source_question_options: format_source_options(source_question_options)
     )
     [
       { role: 'system', content: formatted_system_prompt },
@@ -111,4 +113,13 @@ def parse_llm_response(response)
     )
     fix_parser.parse(response)
   end
+
+  def shuffle_output_options!(parsed_output)
+    return parsed_output unless @shuffle_options
+
+    parsed_output['questions'].each do |question|
+      question['options']&.shuffle!
+    end
+    parsed_output
+  end
 end

spec/services/course/assessment/question/mrq_generation_service_spec.rb

@@ -116,6 +116,63 @@
           expect(result['questions'].length).to eq(1)
         end
       end
+
+      context 'shuffle behavior based on source question options' do
+        let(:mock_options) { [{ 'option' => 'A', 'correct' => true }, { 'option' => 'B', 'correct' => false }] }
+        let(:mock_parsed_output) { { 'questions' => [{ 'title' => 'Q', 'options' => mock_options }] } }
+
+        before do
+          allow(subject).to receive(:parse_llm_response).and_return(mock_parsed_output)
+        end
+
+        context 'when source question has existing options' do
+          let(:params) do
+            {
+              custom_prompt: 'Generate questions about basic mathematics',
+              number_of_questions: 1,
+              source_question_data: {
+                'title' => 'Sample',
+                'description' => 'Desc',
+                'options' => [{ 'option' => 'Option 1', 'correct' => true }]
+              }
+            }
+          end
+
+          it 'does not shuffle the generated options' do
+            expect(mock_options).not_to receive(:shuffle!)
+            subject.generate_questions
+          end
+        end
+
+        context 'when source question options are empty' do
+          let(:params) do
+            {
+              custom_prompt: 'Generate questions about basic mathematics',
+              number_of_questions: 1,
+              source_question_data: { 'title' => 'Sample', 'description' => 'Desc', 'options' => [] }
+            }
+          end
+
+          it 'shuffles the generated options' do
+            expect(mock_options).to receive(:shuffle!)
+            subject.generate_questions
+          end
+        end
+
+        context 'when source_question_data is absent' do
+          let(:params) do
+            {
+              custom_prompt: 'Generate questions about basic mathematics',
+              number_of_questions: 1
+            }
+          end
+
+          it 'shuffles the generated options' do
+            expect(mock_options).to receive(:shuffle!)
+            subject.generate_questions
+          end
+        end
+      end
     end
 
     describe '#format_source_options' do