Apply pvaiko round-4 review items (1-9, 11, 12)

- Fix debug strings: 'Call grain cart' -> 'manual unloader' (CpAIFieldWorker)
- getCombineStrategy(): proxy-first order, remove misleading comment
- driveBesideCombine(): update doc comment; use ppc:getNormalLookaheadDistance() getter
- PurePursuitController: add getNormalLookaheadDistance() getter
- Add AGENTS.md: 'always use getters to access member variables'
- setupFollowCourse(): move manual-combine placeholder logic here, use Course.createStraightForwardCourse
- startCourseFollowingCombine(): remove now-inlined placeholder block and unused followCourseRefreshTime init
- Revert startPathfindingToWaitingCombine to near-upstream (no isManualCombine param/tuning)
- Revert call site and onPathfindingDoneToWaitingCombine redirect-timer init
- Revert driveToCombine() straight-line redirect block
- CollisionAvoidanceController: exclude manual combines from course-intersection check; revert to direct getCpDriveStrategy() call
- getDriveData(): disable PPC off-track check unconditionally when manual proxy is active; remove redundant call from unloadMovingCombine

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: antler22

AGENTS.md

@@ -0,0 +1,5 @@
+# Courseplay Agent Guidelines
+
+## Code Style
+
+- **Always use getters to access member variables.** Do not read fields like `self.ppc.normalLookAheadDistance` directly from outside the owning class; call the appropriate getter instead (e.g. `self.ppc:getNormalLookaheadDistance()`). Add a getter to the class if one does not already exist.

scripts/ai/CollisionAvoidanceController.lua

@@ -58,31 +58,29 @@ end
 
 function CollisionAvoidanceController:findPotentialCollisions()
     for _, vehicle in pairs(g_currentMission.vehicleSystem.vehicles) do
-        if AIDriveStrategyCombineCourse.isActiveCpCombine(vehicle) then
+        if AIDriveStrategyCombineCourse.isActiveCpCombine(vehicle) and
+                not (vehicle.cpIsManualCombineCallingUnloader and vehicle:cpIsManualCombineCallingUnloader()) then
             local d = calcDistanceFrom(self.vehicle.rootNode, vehicle.rootNode)
             if d < self.range then
-                local otherStrategy = vehicle:getCpDriveStrategy()
-                if otherStrategy then
-                    local myCourse = self.strategy:getCurrentCourse()
-                    local otherCourse = otherStrategy:getCurrentCourse()
-                    local myDistanceToCollision, otherDistanceToCollision = myCourse:intersects(otherCourse, self.lookahead, true)
-                    if myDistanceToCollision then
-                        -- our course intersects with this vehicle's course (lastSpeedReal is in m/ms)
-                        -- for our own ETE, we always use the field speed and not the actual speed. This is to make sure
-                        -- we come to a full stop on a warning and remain stopped while the warning is active
-                        local myEte = myDistanceToCollision / (self.strategy:getFieldSpeed())
-                        local otherEte = CpMathUtil.divide(otherDistanceToCollision, (vehicle.lastSpeedReal * 1000))
-                        -- self:debug('Checking %s at %.1f m, %.1f, ETE %.1f %.1f', CpUtil.getName(vehicle), d, myDistanceToCollision, myEte, otherEte)
-                        if math.abs(myEte - otherEte) < self.eteDiffThreshold then
-                            if not self.warning:get() or (self.warning:get() and vehicle ~= self.warningVehicle) then
-                                -- no warning is active yet, or there is, but this is a different vehicle
-                                self:debug('collision warning: my course intersects with %s in %.1f m, my ETE %.1f, other ETE %.1f',
-                                        CpUtil.getName(vehicle), myDistanceToCollision, myEte, otherEte)
-                            end
-                            self.warningVehicle = vehicle
-                            self.warning:set(true, self.clearWarningDelayMs)
-                            return
+                local myCourse = self.strategy:getCurrentCourse()
+                local otherCourse = vehicle:getCpDriveStrategy():getCurrentCourse()
+                local myDistanceToCollision, otherDistanceToCollision = myCourse:intersects(otherCourse, self.lookahead, true)
+                if myDistanceToCollision then
+                    -- our course intersects with this vehicle's course (lastSpeedReal is in m/ms)
+                    -- for our own ETE, we always use the field speed and not the actual speed. This is to make sure
+                    -- we come to a full stop on a warning and remain stopped while the warning is active
+                    local myEte = myDistanceToCollision / (self.strategy:getFieldSpeed())
+                    local otherEte = CpMathUtil.divide(otherDistanceToCollision, (vehicle.lastSpeedReal * 1000))
+                    -- self:debug('Checking %s at %.1f m, %.1f, ETE %.1f %.1f', CpUtil.getName(vehicle), d, myDistanceToCollision, myEte, otherEte)
+                    if math.abs(myEte - otherEte) < self.eteDiffThreshold then
+                        if not self.warning:get() or (self.warning:get() and vehicle ~= self.warningVehicle) then
+                            -- no warning is active yet, or there is, but this is a different vehicle
+                            self:debug('collision warning: my course intersects with %s in %.1f m, my ETE %.1f, other ETE %.1f',
+                                    CpUtil.getName(vehicle), myDistanceToCollision, myEte, otherEte)
                         end
+                        self.warningVehicle = vehicle
+                        self.warning:set(true, self.clearWarningDelayMs)
+                        return
                     end
                 end
             end

scripts/ai/PurePursuitController.lua

@@ -236,6 +236,10 @@ function PurePursuitController:getLookaheadDistance()
     return self.lookAheadDistance
 end
 
+function PurePursuitController:getNormalLookaheadDistance()
+    return self.normalLookAheadDistance
+end
+
 function PurePursuitController:setCurrentLookaheadDistance(cte)
     local la = self.temporaryLookAheadDistance:get() or self.baseLookAheadDistance
     self.lookAheadDistance = math.min(la + math.abs(cte), la * 2)