Optimizar Metodos

Author: Trollhunters501

Nukkit-MOT/src/main/java/org/CreadoresProgram/ViaBedrockDetect/NukkitMain.java

@@ -6,6 +6,7 @@
 import java.util.stream.Collectors;
 public class NukkitMain extends PluginBase{
   private static NukkitMain instance;
+  private static String deviceModelVP = "ViaProxyBedrock";
   public static NukkitMain getInstance(){
     return instance;
   }
@@ -17,7 +18,7 @@ public void onDisable(){
     this.getLogger().info("§cBye!");
   }
   public boolean isJavaPlayer(Player player){
-    return player.isJavaClient() || player.getLoginChainData().getDeviceModel().equals("ViaProxyBedrock");
+    return player.isJavaClient() || player.getLoginChainData().getDeviceModel().equals(deviceModelVP);
   }
   public List<Player> getJavaPlayers(){
     return this.getServer().getOnlinePlayers().values().stream().filter(player -> isJavaPlayer(player)).collect(Collectors.toList());

Nukkit/src/main/java/org/CreadoresProgram/ViaBedrockDetect/NukkitMain.java

@@ -6,6 +6,7 @@
 import java.util.stream.Collectors;
 public class NukkitMain extends PluginBase{
   private static NukkitMain instance;
+  private static String deviceModelVP = "ViaProxyBedrock";
   public static NukkitMain getInstance(){
     return instance;
   }
@@ -17,7 +18,7 @@ public void onDisable(){
     this.getLogger().info("§cBye!");
   }
   public boolean isJavaPlayer(Player player){
-    return player.getLoginChainData().getDeviceModel().equals("ViaProxyBedrock");
+    return player.getLoginChainData().getDeviceModel().equals(deviceModelVP);
   }
   public List<Player> getJavaPlayers(){
     return this.getServer().getOnlinePlayers().values().stream().filter(player -> isJavaPlayer(player)).collect(Collectors.toList());

Pocketmine/plugin/src/org/CreadoresProgram/ViaBedrockDetect/PocketmineMain.php

@@ -5,6 +5,10 @@
 use pocketmine\player\Player;
 class PocketmineMain extends PluginBase{
   private static ?self $instance = null;
+  private static string $deviceModelVP = "ViaProxyBedrock";
+  private static string $deviceModelP = "DeviceModel";
+  private static string $deviceOSP = "DeviceOS";
+  private static string $defDeviceModel = "";
   public static function getInstance() : ?self{
     return self::$instance;
   }
@@ -16,8 +20,8 @@ public function onDisable() : void{
   }
   public function isJavaPlayer(Player $player) : bool{
     $extraData = $player->getNetworkSession()->getPlayerInfo()->getExtraData();
-    $deviceModel = $extraData["DeviceModel"] ?? "";
-    return ($deviceModel == "ViaProxyBedrock");
+    $deviceModel = $extraData[self::$deviceModelP] ?? self::$defDeviceModel;
+    return ($deviceModel == self::$deviceModelVP);
   }
   public function getJavaPlayers() : array{
     return array_filter($this->getServer()->getOnlinePlayers(), fn($player) => $this->isJavaPlayer($player));

ViaProxy/src/main/java/org/CreadoresProgram/ViaBedrockDetect/ViaProxyMain.java

@@ -10,6 +10,9 @@
 import java.util.Map;
 public class ViaProxyMain extends ViaProxyPlugin{
   private String prefix = "[ViaBedrockDetect] ";
+  private String DeviceOs = "DeviceOS";
+  private String DeviceModel = "DeviceModel";
+  private String DeviceModelVal = "ViaProxyBedrock";
   @Override
   public void onEnable(){
     System.out.println(prefix + "Loading ViaBedrockDetect...");
@@ -26,8 +29,8 @@ public void onViaLoading(ViaLoadingEvent event){
       @Override
       public Map<String, Object> getClientPlayerSkin(final UserConnection user){
         final Map<String, Object> claims = super.getClientPlayerSkin(user);
-        claims.put("DeviceOS", BuildPlatform.UWP.getValue());
-        claims.put("DeviceModel", "ViaProxyBedrock");
+        claims.put(DeviceOs, BuildPlatform.UWP.getValue());
+        claims.put(DeviceModel, DeviceModelVal);
         return claims;
       }
     });