refactor: initialize Isar in main.dart to prevent race conditions and simplify controllers

Author: CreatorJohn

lib/main.dart

@@ -3,12 +3,16 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:off_chat/src/app.dart';
 import 'package:off_chat/src/core/utils/watch_log.dart';
 import 'package:off_chat/src/core/notifications/notification_service.dart';
+import 'package:off_chat/src/core/database/isar_service.dart';
 
 void main() async {
   WidgetsFlutterBinding.ensureInitialized();
 
   // Setup hardened logging
   await WatchLog.initialize();
+
+  // Initialize database
+  await IsarService().initialize();
 
   // Initialize notifications
   await NotificationService().init();

lib/src/core/database/database_provider.dart

@@ -6,12 +6,8 @@ import 'package:shared_preferences/shared_preferences.dart';
 part 'database_provider.g.dart';
 
 @Riverpod(keepAlive: true)
-Future<Isar> isarDatabase(Ref ref) async {
-  final service = IsarService();
-  if (!service.isOpen) {
-    await service.initialize();
-  }
-  return service.db;
+Isar isarDatabase(Ref ref) {
+  return IsarService().db;
 }
 
 @Riverpod(keepAlive: true)

lib/src/features/chat/presentation/chat_controller.dart

@@ -13,15 +13,9 @@ part 'chat_controller.g.dart';
 class ChatController extends _$ChatController {
   @override
   Stream<List<Message>> build(String remoteDeviceId) {
-    // Ensure Isar is initialized
-    final isarAsync = ref.watch(isarDatabaseProvider);
-    
-    if (isarAsync.hasValue) {
-      final stableId = int.parse(remoteDeviceId);
-      return IsarService().watchMessagesWithDevice(stableId);
-    }
-    
-    return const Stream.empty();
+    ref.watch(isarDatabaseProvider);
+    final stableId = int.parse(remoteDeviceId);
+    return IsarService().watchMessagesWithDevice(stableId);
   }
 
   Future<void> sendTextMessage(String text) async {

lib/src/features/discovery/presentation/discovery_controller.dart

@@ -10,15 +10,8 @@ part 'discovery_controller.g.dart';
 class DiscoveryController extends _$DiscoveryController {
   @override
   Stream<List<FoundDevice>> build() {
-    // Watch the provider to ensure Isar is initialized
-    final isarAsync = ref.watch(isarDatabaseProvider);
-    
-    if (isarAsync.hasValue) {
-      return IsarService().watchFoundDevices();
-    }
-    
-    // Return empty stream while initializing
-    return const Stream.empty();
+    ref.watch(isarDatabaseProvider);
+    return IsarService().watchFoundDevices();
   }
 
   Future<void> manualRefresh() async {