fix(ci): clear all 7 pre-existing pytest failures

Picks up where the previous mypy fix (d671910) left off — pytest is now
the visible failure surface, with 7 distinct tests red across all 3
Python versions in the matrix.  All four root causes are real bugs
unrelated to recent feature work, just never noticed because mypy
was failing before pytest got a chance to run.

1. webdav_provider.get_content() — auth lookup now happens AFTER the
   pending-shortcut check.
   Pending uploads (uuid='pending-...') and missing-uuid resources
   return io.BytesIO(b"") immediately without touching auth_service.
   Fixes:
     test_get_content_returns_empty_for_pending_resource
     test_get_content_returns_empty_when_no_uuid

2. webdav_server.start() — server_choice validation now runs first.
   Previously, an invalid choice fell through to provider construction
   (which calls auth) and surfaced a MissingCredentialsError before
   reaching the explicit ValueError that the test expects.  Moved the
   {'auto','waitress','cheroot'} check to the top of try-block.
   Fixes:
     test_invalid_server_choice_does_not_unbound_local

3. drive._available_memory() — Linux fallback now gated on
   sys.platform.startswith('linux').
   The else-branch read /proc/meminfo for any non-darwin / non-win32
   platform, including the synthetic 'unknown-os' that the test patches
   sys.platform to in order to force the 4 GB fallback.  Now only Linux
   takes that branch; everything else falls through.
   Fixes:
     test_available_memory_falls_back_to_4gb_when_all_probes_fail

4. requirements-dev.txt — added `cheroot>=10.0`.
   tests/test_webdav_server_start_branches.py exercises the cheroot
   branch in start() via sys.modules injection, but `from cheroot
   import wsgi` first imports the cheroot package itself, which is not
   installed on CI (only waitress is in requirements.txt).  Adding
   cheroot to dev requirements makes the test pass without changing
   production install (CI uses requirements-dev.txt; users still install
   from requirements.txt).
   Fixes:
     test_explicit_cheroot_choice_uses_cheroot
     test_https_with_cheroot_attempts_ssl_setup
     test_https_with_cheroot_generates_certs_when_missing

Verified locally:
  $ mypy --no-incremental cli.py services
  Success: no issues found in 8 source files
  $ pytest tests/ -q --ignore=tests/test_live_smoke.py
  ............................. 100%

No behaviour change in any happy-path runtime flow — every fix is a
control-flow tightening that makes the suite pass without touching
the operations the suite was already verifying.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: CrispStrobe

requirements-dev.txt

@@ -14,3 +14,10 @@ python-dotenv>=1.0.0
 # (rate limiting / eventual consistency). Required for tests/test_live_smoke.py
 # to be reliable end-to-end; not used by the main unit suite.
 pytest-rerunfailures>=12.0
+
+# Optional WSGI server, alternative to waitress.  Production code probes
+# both at runtime (services/webdav_server.py) and tests in
+# tests/test_webdav_server_start_branches.py exercise the cheroot branch
+# explicitly — they need it importable to reach the FakeCherootServer
+# stub injected via sys.modules.
+cheroot>=10.0

services/drive.py

@@ -98,8 +98,10 @@ class MEMORYSTATUSEX(ctypes.Structure):
                 stat = MEMORYSTATUSEX(dwLength=ctypes.sizeof(MEMORYSTATUSEX))
                 ctypes.windll.kernel32.GlobalMemoryStatusEx(ctypes.byref(stat))
                 return stat.ullAvailPhys
-            else:
-                # Linux / other Unix: read from /proc/meminfo
+            elif sys.platform.startswith('linux'):
+                # Read from /proc/meminfo (Linux only — gated explicitly so
+                # tests that patch sys.platform to a synthetic value can
+                # exercise the 4 GB fallback below).
                 with open('/proc/meminfo') as f:
                     for line in f:
                         if line.startswith('MemAvailable:'):

services/webdav_provider.py

@@ -309,14 +309,18 @@ def get_content(self) -> Union[bytes, io.BytesIO]:
         try:
             from services.drive import drive_service
             from services.auth import auth_service
-            
-            credentials = auth_service.get_auth_details()
-            user = credentials['user']
-            mnemonic = user['mnemonic']
-            
+
+            # Pending uploads + missing uuids return an empty body without
+            # touching the auth service (no creds needed for a 0-byte read).
+            # This also makes get_content() callable from unit tests that
+            # don't bother mocking auth_service.
             file_uuid = self.file_metadata.get('uuid')
             if not file_uuid or file_uuid.startswith('pending-'):
                 return io.BytesIO(b"")
+
+            credentials = auth_service.get_auth_details()
+            user = credentials['user']
+            mnemonic = user['mnemonic']
 
             print(f"📥 WEBDAV: Downloading file {file_uuid} for streaming...")
 

services/webdav_server.py

@@ -136,11 +136,22 @@ def start(self, port: Optional[int] = None, background: bool = False,
             Dict with success status, message, and URL
         """
         try:
+            # Validate server_choice up-front, before any auth-requiring
+            # setup (provider construction reads credentials).  An invalid
+            # server choice should fail with the explicit ValueError below
+            # regardless of login state — useful when a CI / unit test runs
+            # without credentials.
+            if server_choice not in ('auto', 'waitress', 'cheroot'):
+                raise ValueError(
+                    f"Unknown server choice '{server_choice}'. "
+                    "Use 'auto', 'waitress', or 'cheroot'."
+                )
+
             from wsgidav.wsgidav_app import WsgiDAVApp
             from services.webdav_provider import InternxtDAVProvider
             # Import for SSL
             from services.network_utils import NetworkUtils
-            
+
             # Get configuration
             webdav_config = config_service.read_webdav_config()