Skip to content

Fix/ldap injection #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itssherwin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/ldap injection #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f91480c
fix: prevent LDAP injection by validating and escaping username input
itssherwin Jul 23, 2025
f9e862c
Update index.php
itssherwin Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions oauth/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,22 @@ function messageShow($html_template, $message = 'No Msg') {
$user=strtolower(strip_tags(htmlspecialchars(trim($_POST['user']))));
$password=$_POST['password'];

// Sherwin Ldap-escape
if (!filter_var($user, FILTER_VALIDATE_EMAIL)) {
messageShow($prompt_template, 'Username contains invalid charecters.');
exit();
}

if (!function_exists('ldap_escape')) {
function ldap_escape($value) {
return preg_replace_callback('/[\\x00-\\x1F\\x7F\\(\\)\\\\\\*\\0]/', function ($matches) {
return '\\' . str_pad(dechex(ord($matches[0])), 2, '0', STR_PAD_LEFT);
}, $value);
}
}
$user = ldap_escape($user);
// Sherwin Ldap-escape

// Open a LDAP connection
$ldap = new LDAP($ldap_host,$ldap_port,$ldap_version,$ldap_start_tls);

Expand Down