Make night product failures visible and improve tool discoverability#924
Open
dvida wants to merge 2 commits into
Open
Make night product failures visible and improve tool discoverability#924dvida wants to merge 2 commits into
dvida wants to merge 2 commits into
Conversation
Promote the exception handlers around night product generation in Reprocess (calibration report, observation summary, timelapse, flat, shower association, FOV KML, flux files, field sums, FT archiving, config audit, timestamp plot) from log.debug to log.warning so failures reach the uploaded night logs instead of being silently swallowed. Route ConfigReader validation warnings (FPS clamp, FOV check, jpg/png ranges, binning factor/method, band ratios, upload disabled on the default station code) through logging instead of print(), so they also land in the night logs with a level and timestamp. Add an on-screen key legend to FRbinViewer (toggled with 'h') - the keys were previously only documented in the --help epilog. Document the runnable RMS/ pipeline modules in Utils/README.md, which previously only cataloged the Utils/ scripts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50500de2c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ArchiveDetections, UploadManager, DownloadPlatepar, and CaptureModeSwitcher have hardcoded test stubs in their __main__ blocks rather than user CLIs, so following the README could trigger unintended test file/network operations. Mark them as internal instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RMS/Reprocess.py: promotes the exception handlers around night product generation (calibration report, observation summary, timelapse, flat, shower association, FOV KML, flux files, field sums, FT archiving, config audit, timestamp plot) fromlog.debugtolog.warning. When the "did my night work?" artifacts fail to generate, the failure now reaches the uploaded night logs instead of being silently swallowed at debug level.RMS/ConfigReader.py: routes validation warnings throughlogginginstead ofprint()(FPS clamp, FOV check, jpg/png quality ranges, binning factor/method, band ratios, upload disabled on the default XX0001 station code), so they land in the night logs with a level and timestamp.Utils/FRbinViewer.py: on-screen key legend (SPACE pause | 1 prev file | 2 next line | q quit), toggled withh. The keys were previously only visible in the--helpepilog.Utils/README.md: new section cataloging the runnableRMS/pipeline modules (StartCapture, Reprocess, DetectStarsAndMeteors, ...), which were previously undocumented there.Testing
initLogging)python -m Utils.FRbinViewer -hshows the updated key mapping; legend drawing uses the existingaddTextToImageoverlay path🤖 Generated with Claude Code