Skip to content

Feature/link tag#40

Draft
Fooooooooooox wants to merge 7 commits intomainfrom
feature/link-tag
Draft

Feature/link tag#40
Fooooooooooox wants to merge 7 commits intomainfrom
feature/link-tag

Conversation

@Fooooooooooox
Copy link
Copy Markdown
Contributor

@Fooooooooooox Fooooooooooox commented Feb 6, 2023

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • I have updated the abi and docs
  • I tested locally to make sure this feature/fix works

github-advanced-security[bot]
github-advanced-security AI found potential problems Feb 6, 2023
View reviewed changes
Comment thread contracts/storage/LinklistStorage.sol Outdated
// linklistId => address => tags
mapping(uint256 => mapping(address => EnumerableSet.Bytes32Set)) internal _linkedAdressTags;
// linklistId => address => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedUriTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedERC721Tags (contracts/storage/LinklistStorage.sol#57) is not in mixedCase
Comment thread contracts/storage/LinklistStorage.sol Outdated
// linklistId => address => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedUriTags;
// linklistId => linklistId => tags
mapping(uint256 => mapping(uint256 => EnumerableSet.Bytes32Set)) internal _linkedLinklistTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedAdressTags (contracts/storage/LinklistStorage.sol#59) is not in mixedCase
Comment thread contracts/libraries/Constants.sol Outdated
Comment on lines 31 to 32

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Constant Constants.NoteLinkTag (contracts/libraries/Constants.sol#31-32) is not in UPPER_CASE_WITH_UNDERSCORES
Comment thread contracts/libraries/Constants.sol Outdated
Comment on lines 34 to 35

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Constant Constants.UriLinkTag (contracts/libraries/Constants.sol#34-35) is not in UPPER_CASE_WITH_UNDERSCORES
Comment thread contracts/storage/LinklistStorage.sol Outdated

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedUriTags (contracts/storage/LinklistStorage.sol#61) is not in mixedCase
Comment thread contracts/storage/LinklistStorage.sol Outdated
// linklistId => linkKey => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set))
internal _linkedCharacterLinkTags;
// linklistId => linkKey => tags

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedNoteTags (contracts/storage/LinklistStorage.sol#52) is not in mixedCase
Comment thread contracts/storage/LinklistStorage.sol Outdated
Comment on lines +54 to +55
// linklistId => address => tags
mapping(uint256 => mapping(address => EnumerableSet.Bytes32Set)) internal _linkedAdressTags;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedCharacterLinkTags (contracts/storage/LinklistStorage.sol#54-55) is not in mixedCase
Comment thread contracts/storage/LinklistStorage.sol Outdated

// linkKey sets
// tokenId => linkKeys
// linklistId => linkKeys

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._uris (contracts/storage/LinklistStorage.sol#39) is not in mixedCase
Comment thread contracts/storage/LinklistStorage.sol Outdated
// linklistId => linkKey => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set)) internal _linkedNoteTags;
// linklistId => linkKey => tags
mapping(uint256 => mapping(bytes32 => EnumerableSet.Bytes32Set))

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedCharacterTags (contracts/storage/LinklistStorage.sol#50) is not in mixedCase
Comment thread contracts/storage/LinklistStorage.sol Outdated

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable LinklistStorage._linkedLinklistTags (contracts/storage/LinklistStorage.sol#63) is not in mixedCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fooooooooooox @github-advanced-security