Do not compress when body is empty

paulharris · gittiver · commit 40c9aada4640 · 2024-10-21T22:07:01.000+02:00
This resolves #920 ... keep the body empty if already empty. Compression adds compression headers and overhead, and breaks assumptions later on when processing (eg) error 404.
diff --git a/include/crow/http_connection.h b/include/crow/http_connection.h
@@ -231,7 +231,7 @@ namespace crow
                   decltype(*middlewares_)>({}, *middlewares_, ctx_, req_, res);
             }
 #ifdef CROW_ENABLE_COMPRESSION
-            if (handler_->compression_used())
+            if (!res.body.empty() && handler_->compression_used())
             {
                 std::string accept_encoding = req_.get_header_value("Accept-Encoding");
                 if (!accept_encoding.empty() && res.compressed)

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ namespace crow`
`231`	`231`	`decltype(middlewares_)>({}, middlewares_, ctx_, req_, res);`
`232`	`232`	`}`
`233`	`233`	`#ifdef CROW_ENABLE_COMPRESSION`
`234`		`- if (handler_->compression_used())`
	`234`	`+ if (!res.body.empty() && handler_->compression_used())`
`235`	`235`	`{`
`236`	`236`	`std::string accept_encoding = req_.get_header_value("Accept-Encoding");`
`237`	`237`	`if (!accept_encoding.empty() && res.compressed)`