Use C locale for cookie Expires date formatting

Sightem · Sightem · commit b7b229e700de · 2025-04-20T13:42:06.000-07:00
diff --git a/include/crow/middlewares/cookie_parser.h b/include/crow/middlewares/cookie_parser.h
@@ -67,8 +67,16 @@ namespace crow
                 dumpString(ss, httponly_, "HttpOnly");
                 if (expires_at_)
                 {
-                    ss << DIVIDER << "Expires="
-                       << std::put_time(expires_at_.get(), HTTP_DATE_FORMAT);
+                    std::string old_locale_cstr = std::setlocale(LC_TIME, nullptr);
+                    std::setlocale(LC_TIME, "C");
+
+                    char buf[100];
+                    if (std::strftime(buf, sizeof(buf), HTTP_DATE_FORMAT, expires_at_.get()))
+                    {
+                        ss << DIVIDER << "Expires=" << buf;
+                    }
+
+                    std::setlocale(LC_TIME, old_locale_cstr.c_str());
                 }
                 if (max_age_)
                 {

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,16 @@ namespace crow`
`67`	`67`	`dumpString(ss, httponly_, "HttpOnly");`
`68`	`68`	`if (expires_at_)`
`69`	`69`	`{`
`70`		`- ss << DIVIDER << "Expires="`
`71`		`- << std::put_time(expires_at_.get(), HTTP_DATE_FORMAT);`
	`70`	`+ std::string old_locale_cstr = std::setlocale(LC_TIME, nullptr);`
	`71`	`+ std::setlocale(LC_TIME, "C");`
	`72`	`+`
	`73`	`+ char buf[100];`
	`74`	`+ if (std::strftime(buf, sizeof(buf), HTTP_DATE_FORMAT, expires_at_.get()))`
	`75`	`+ {`
	`76`	`+ ss << DIVIDER << "Expires=" << buf;`
	`77`	`+ }`
	`78`	`+`
	`79`	`+ std::setlocale(LC_TIME, old_locale_cstr.c_str());`
`72`	`80`	`}`
`73`	`81`	`if (max_age_)`
`74`	`82`	`{`