Clean up: Relocate Method to HTTP server#1049
Conversation
gittiver
left a comment
There was a problem hiding this comment.
To be honest, I would prefer to have the function in app and app.h, as also the other functions related to web sockets are there and the only usage too.
Would spare also the function argument.
|
I just did what the TODO said wanting to contribute. Honestly though I think it looks prettier and logical more concise as the logic is related to http server functionality |
|
if you want I could also move add_websocket and remove_websocket also in htttp_server? |
I agree, but then we have to move the web sockets list and the other function also to http_server. |
ok i followed your request and i will start to analyze the classes that will affected and how to move the logic of websockets to http_server |
This PR addresses the Todo comment :
// TODO(EDev): Move these 6 lines to a method in http_server.