Adds Boost to ci#1071
Merged
Merged
Conversation
Contributor
Author
|
The CI needs to be run again after the merge of #1070 |
gittiver
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compilation error reported in #1069 made it to master because the the cmake variable
CROW_USE_BOOSTis set to false in all the CI combinations.This PR adds to the CI matrix the
asio_typeoption which is only populated forubuntu-latest. In practice this adds an additional workflow to the CI which builds and tests using boost::asio instead of standalone asio.This should prevent compilation or functional error to reach master when these errors only arise when using boost::asio.