Refactor routing_params test and isolate HTTP response tests#1088
Merged
gittiver merged 3 commits intoSep 17, 2025
Merged
Conversation
- Moved tests that depend solely on `crow::response` from unittest.cpp to tests/unit_tests/test_http_response.cpp for clearer separation of concerns. - Renamed the original "simple_response_routing_params" test in unittest.cpp to "routing_params" to reflect this chage. - Updated CMakeLists.txt to automatically include all sources under unit_tests/.
gittiver
approved these changes
Sep 15, 2025
gittiver
requested changes
Sep 16, 2025
gittiver
left a comment
Member
There was a problem hiding this comment.
please replace globbing by explicit file listing
gittiver
reviewed
Sep 16, 2025
gittiver
previously approved these changes
Sep 17, 2025
gittiver
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests that only depend on
crow::responsewere moved tounit_tests/test_http_response.cpp.This is a proof-of-concept for splitting the monolithic file
uinttest.cppinto multiple files that map one-to-one to files ininclude/crow.The aims of this refactor are to:
Below is a comparison between outputs before and after the refactor to validate that only the intended changes were made.
tests/unittest:
There is one more test than before because "simple_response_routing_params" was split into "simple_response" and "routing_params".
Before:
After:
test/unittest "custom_content_type"
No change.
Before:
After:
test/unittest "simple_response_routing_params":
Outputs are equivalent in aggregate.
Before:
After: