Refactor/isolate mustache tests#1093
Merged
gittiver merged 9 commits intoSep 21, 2025
Merged
Conversation
- Moved tests that depend solely on `crow::response` from unittest.cpp to tests/unit_tests/test_http_response.cpp for clearer separation of concerns. - Renamed the original "simple_response_routing_params" test in unittest.cpp to "routing_params" to reflect this chage. - Updated CMakeLists.txt to automatically include all sources under unit_tests/.
Isolated unit tests that depend only on the utility module into test_utility.cpp.
- Moved Mustache-related tests from unittest.cpp to a new file: test_mustache.cpp - Added coverage for: * Nested keys (e.g., user.name, user.address.city) * Function-returned template strings (including empty strings) * Lists and inverse/else blocks * HTML escaping, triple mustache, and unescaped tags * Custom template loader and partials * Multiline templates with proper indentation * Numeric and boolean values - Removed Mustache tests from unittest.cpp for better organization - Updated CMakeLists.txt to list test files explicitly (no globbing).
Member
|
CMake Error at tests/CMakeLists.txt:35 (add_executable): |
gittiver
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued refactor of
unittest.cppby moving mustache-related tests tounit_tests/test_mustache.cpp.Improved test coverage of mustache by adding 12 additional unit tests.
Additionally removed gobbing of test files form
CMakeLists.txtand instead included test files explicitly.