Fix heap-buffer-overflow in query_string when parsing malformed '%'Fix heap-buffer-overflow in query_string for malformed '%'#1134
Merged
gittiver merged 2 commits intoFeb 25, 2026
Conversation
gittiver
reviewed
Jan 18, 2026
gittiver
requested changes
Jan 19, 2026
Contributor
Author
|
test_fix has been deleted |
gittiver
approved these changes
Feb 25, 2026
gittiver
added a commit
that referenced
this pull request
Mar 29, 2026
…gfix release * master: (22 commits) fix#1165: sanitize header values to prevent injection and add helloworld_inject example (#1167) Handle headers for HTTPMethod::Options Fix build on OpenBSD (#1162) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Feature#1129-CMake Error: ALIAS target "Boost::system" name collision when using vcpkg and FetchContent (#1133) Fix heap-buffer-overflow in query_string when parsing malformed '%'Fix heap-buffer-overflow in query_string for malformed '%' (#1134) Minor features to crow::json::wvalue (#1143) ... # Conflicts: # .github/workflows/build_and_test.yml
gittiver
added a commit
that referenced
this pull request
Mar 29, 2026
…gfix release * master: (22 commits) fix#1165: sanitize header values to prevent injection and add helloworld_inject example (#1167) Handle headers for HTTPMethod::Options Fix build on OpenBSD (#1162) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Feature#1129-CMake Error: ALIAS target "Boost::system" name collision when using vcpkg and FetchContent (#1133) Fix heap-buffer-overflow in query_string when parsing malformed '%'Fix heap-buffer-overflow in query_string for malformed '%' (#1134) Minor features to crow::json::wvalue (#1143) ... # Conflicts: # .github/workflows/build_and_test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #1126.
Problem:
Malformed percent-encoding (e.g. trailing '%') caused an out-of-bounds
read in the query_string parser.
Fix:
Added bounds checking before decoding percent-encoded sequences to
avoid reading past the buffer.
Testing:
Fixes #1126