Skip to content

fix #1040: append the last crlf if miss for multipart data #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notfresh wants to merge 3 commits into from
Closed

fix #1040: append the last crlf if miss for multipart data #1135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9eedbb
fix #1040: append the last crlf if miss for multipart data
notfresh Jan 22, 2026
dc1b0df
fix #1040: append the last crlf if miss for multipart data with sel…
notfresh Jan 22, 2026
31bdcc9
fix: keep ends_with simple
notfresh Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion include/crow/multipart.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,19 @@ namespace crow
return std::string();
}

// cpp17(cpp 20 have) does not have ends_with, so we need to implement it ourselves
bool ends_with(const std::string& str, const std::string& suffix) {
if (suffix.size() > str.size()) return false;
return std::equal(suffix.rbegin(), suffix.rend(), str.rbegin());
}

void parse_body(std::string body)
{
std::string delimiter = dd + boundary;

if(!ends_with(body, crlf))
{
body += crlf;
}
// TODO(EDev): Exit on error
while (body != (crlf))
{
Expand Down
Loading