Protect websockets_ by mutex#1136
Merged
Merged
Conversation
3f57458 to
483f5cc
Compare
6aa8b2e to
6e5977f
Compare
gittiver
reviewed
Jan 25, 2026
gittiver
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We faced the situation, when
std::vector<std::shared_ptr<websocket::connection>> websockets_will be modified in several threads in case of several simultaneous connections been opened and closed.To prove this and for future needs, we added ThreadSanitizer support (ENABLE_TSAN flag) and new test (multithreaded_websockets_open_close) that shows this problem:
So, protected websockets_ usage with new mutex.