Skip to content

Minor features to crow::json::wvalue#1143

Merged
gittiver merged 9 commits into
CrowCpp:masterfrom
CarloDG80:localDev
Feb 22, 2026
Merged

Minor features to crow::json::wvalue#1143
gittiver merged 9 commits into
CrowCpp:masterfrom
CarloDG80:localDev

Conversation

@CarloDG80
Copy link
Copy Markdown
Contributor

@CarloDG80 CarloDG80 commented Feb 10, 2026 •
edited
Loading

Add minor features to crow::json::wvalue:

  • has(key) -> bool
  • operator std::string()
  • toStr() -> std::string

gittiver
gittiver reviewed Feb 11, 2026
View reviewed changes
Comment thread include/crow/json.h Outdated
gittiver
gittiver reviewed Feb 11, 2026
View reviewed changes
Comment thread include/crow/json.h Outdated
gittiver
gittiver reviewed Feb 11, 2026
View reviewed changes
Comment thread include/crow/settings.h Outdated
gittiver
gittiver requested changes Feb 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gittiver gittiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments on changes

@gittiver gittiver marked this pull request as draft February 11, 2026 23:04
@gittiver
Copy link
Copy Markdown
Member

gittiver commented Feb 11, 2026

set back to draft as it does not compile

@CarloDG80 CarloDG80 requested a review from gittiver February 12, 2026 15:52
@gittiver gittiver changed the title Minor features to crow::json::wvalue & Logging Minor features to crow::json::wvalue Feb 13, 2026
@CarloDG80 CarloDG80 marked this pull request as ready for review February 17, 2026 15:27
@gittiver gittiver merged commit b8c021a into CrowCpp:master Feb 22, 2026
19 checks passed
@CarloDG80 CarloDG80 deleted the localDev branch March 4, 2026 15:03
gittiver added a commit that referenced this pull request Mar 29, 2026
@gittiver
Merge branch 'master' into v1.3 to get sanitize header fix for new bu…
79728c4 
…gfix release

* master: (22 commits)
  fix#1165: sanitize header values to prevent injection and add helloworld_inject example (#1167)
  Handle headers for HTTPMethod::Options
  Fix build on OpenBSD (#1162)
  Enable compiler sanitizers for test builds (Fixes #1137)
  Enable compiler sanitizers for test builds (Fixes #1137)
  Enable compiler sanitizers for test builds (Fixes #1137)
  Feature#1129-CMake Error: ALIAS target "Boost::system" name collision when using vcpkg and FetchContent (#1133)
  Fix heap-buffer-overflow in query_string when parsing malformed '%'Fix heap-buffer-overflow in query_string for malformed '%' (#1134)
  Minor features to crow::json::wvalue (#1143)
  ...

# Conflicts:
#	.github/workflows/build_and_test.yml
gittiver added a commit that referenced this pull request Mar 29, 2026
@gittiver
Merge branch 'master' into v1.3 to get sanitize header fix for new bu…
f8c060c 
…gfix release

* master: (22 commits)
  fix#1165: sanitize header values to prevent injection and add helloworld_inject example (#1167)
  Handle headers for HTTPMethod::Options
  Fix build on OpenBSD (#1162)
  Enable compiler sanitizers for test builds (Fixes #1137)
  Enable compiler sanitizers for test builds (Fixes #1137)
  Enable compiler sanitizers for test builds (Fixes #1137)
  Feature#1129-CMake Error: ALIAS target "Boost::system" name collision when using vcpkg and FetchContent (#1133)
  Fix heap-buffer-overflow in query_string when parsing malformed '%'Fix heap-buffer-overflow in query_string for malformed '%' (#1134)
  Minor features to crow::json::wvalue (#1143)
  ...

# Conflicts:
#	.github/workflows/build_and_test.yml
@BrewTestBot BrewTestBot mentioned this pull request Mar 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gittiver gittiver gittiver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CarloDG80 @gittiver