From 93d268328d06cb105065f98c33fb634411c1545d Mon Sep 17 00:00:00 2001 From: Carlo Del Grosso Date: Thu, 12 Feb 2026 15:08:42 +0100 Subject: [PATCH 1/3] crow/logging.h : add "empty" macros in case of CROW_ENABLE_LOGGING is undefined --- include/crow/logging.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/include/crow/logging.h b/include/crow/logging.h index 1854f64e9..2e0127dfe 100644 --- a/include/crow/logging.h +++ b/include/crow/logging.h @@ -158,6 +158,7 @@ namespace crow }; } // namespace crow +#ifdef CROW_ENABLE_LOGGING #define CROW_LOG_CRITICAL \ if (crow::logger::get_current_log_level() <= crow::LogLevel::Critical) \ crow::logger(crow::LogLevel::Critical) @@ -173,3 +174,23 @@ namespace crow #define CROW_LOG_DEBUG \ if (crow::logger::get_current_log_level() <= crow::LogLevel::Debug) \ crow::logger(crow::LogLevel::Debug) + +#else +#define CROW_LOG_CRITICAL \ + if (false) \ + crow::logger(crow::LogLevel::Critical) +#define CROW_LOG_ERROR \ + if (false) \ + crow::logger(crow::LogLevel::Error) +#define CROW_LOG_WARNING \ + if (false) \ + crow::logger(crow::LogLevel::Warning) +#define CROW_LOG_INFO \ + if (false) \ + crow::logger(crow::LogLevel::Info) +#define CROW_LOG_DEBUG \ + if (false) \ + crow::logger(crow::LogLevel::Debug) + + +#endif From 09db32c0392c685f605776800e91ed41d8385198 Mon Sep 17 00:00:00 2001 From: Carlo Del Grosso Date: Thu, 12 Feb 2026 16:06:59 +0100 Subject: [PATCH 2/3] Add unused patch to remove compiler warnings --- include/crow/logging.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/crow/logging.h b/include/crow/logging.h index 2e0127dfe..c9b1b78e0 100644 --- a/include/crow/logging.h +++ b/include/crow/logging.h @@ -127,6 +127,8 @@ namespace crow { stringstream_ << value; } +#else + ((void)(value)); // Remove unused warning #endif return *this; } From 00717bc761957fce252c1999ebcca8007e39d5f5 Mon Sep 17 00:00:00 2001 From: Carlo Del Grosso Date: Thu, 12 Feb 2026 17:13:07 +0100 Subject: [PATCH 3/3] Column alignment of backslash --- include/crow/logging.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/crow/logging.h b/include/crow/logging.h index c9b1b78e0..174dfff9c 100644 --- a/include/crow/logging.h +++ b/include/crow/logging.h @@ -178,20 +178,20 @@ namespace crow crow::logger(crow::LogLevel::Debug) #else -#define CROW_LOG_CRITICAL \ - if (false) \ +#define CROW_LOG_CRITICAL \ + if (false) \ crow::logger(crow::LogLevel::Critical) -#define CROW_LOG_ERROR \ - if (false) \ +#define CROW_LOG_ERROR \ + if (false) \ crow::logger(crow::LogLevel::Error) -#define CROW_LOG_WARNING \ - if (false) \ +#define CROW_LOG_WARNING \ + if (false) \ crow::logger(crow::LogLevel::Warning) #define CROW_LOG_INFO \ - if (false) \ + if (false) \ crow::logger(crow::LogLevel::Info) -#define CROW_LOG_DEBUG \ - if (false) \ +#define CROW_LOG_DEBUG \ + if (false) \ crow::logger(crow::LogLevel::Debug)