Fix build on OpenBSD#1162
Merged
Merged
Conversation
|
I don't have access to an OpenBSD box, but what about using |
Contributor
Author
|
Yeah, that would probably actually do it. I'll take a look at this today. |
Contributor
Author
|
Should be good now |
gittiver
approved these changes
Mar 17, 2026
gittiver
added a commit
that referenced
this pull request
Mar 29, 2026
…gfix release * master: (22 commits) fix#1165: sanitize header values to prevent injection and add helloworld_inject example (#1167) Handle headers for HTTPMethod::Options Fix build on OpenBSD (#1162) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Feature#1129-CMake Error: ALIAS target "Boost::system" name collision when using vcpkg and FetchContent (#1133) Fix heap-buffer-overflow in query_string when parsing malformed '%'Fix heap-buffer-overflow in query_string for malformed '%' (#1134) Minor features to crow::json::wvalue (#1143) ... # Conflicts: # .github/workflows/build_and_test.yml
gittiver
added a commit
that referenced
this pull request
Mar 29, 2026
…gfix release * master: (22 commits) fix#1165: sanitize header values to prevent injection and add helloworld_inject example (#1167) Handle headers for HTTPMethod::Options Fix build on OpenBSD (#1162) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Enable compiler sanitizers for test builds (Fixes #1137) Feature#1129-CMake Error: ALIAS target "Boost::system" name collision when using vcpkg and FetchContent (#1133) Fix heap-buffer-overflow in query_string when parsing malformed '%'Fix heap-buffer-overflow in query_string for malformed '%' (#1134) Minor features to crow::json::wvalue (#1143) ... # Conflicts: # .github/workflows/build_and_test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenBSD uses a <C11 version of the C standard in some places, with the lack of DBL_DECIMAL_DIG being a problem in regards to CrowCPP.
The fix for this is is just defining it as 17, which while certainly not perfect, is as good as you can get. 17 is the value it has on x86, ARM, i386, PowerPC and RISC-V, at least. Suffice to say, it should not cause problems expect possibly with some obscure embedded architectures.
It's value is not directly tied to any other constants, so there are no fully portable fixes for this issue.
The location in code is a bit ugly and could be changed, but I am unsure as to where it should be located.