Merging build#1195
Open
RndU53r wants to merge 2 commits into
Open
Conversation
- examples/hello_world/main.cpp: minimal Crow HTTP server returning "Hello, World!" on GET / - examples/hello_world/CMakeLists.txt: self-contained CMake build that uses the vendored Asio; no system-wide dependency install required - third_party/asio*: Asio 1.x (standalone) headers vendored from Homebrew; removes the need for any external package manager on all three platforms - docs/building.md: step-by-step build guide for macOS, Linux, and Windows covering both the CMake path and the raw compiler command - .gitignore: ignore generated hello_world build artifacts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add hello_world example, vendor Asio, and cross-platform build docs
Author
|
approved |
gittiver
reviewed
Jun 25, 2026
gittiver
left a comment
gittiver
left a comment
Member
There was a problem hiding this comment.
What is the reason for adding a copy of the asio lib?
I would propose to leave the asio lib separate, we could add an internal version with CPM macro but I would couple that with an additional build option (USE_INTERNAL_ASIO).
regarding building.md - its already in docs/getting_started/setup splitted by OS. So we should integrate the contents there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.