Fix #1199: correct ownership transfer in json::detail::r_string move operations (prevent leaks and invalid frees)#1200
Open
jwolak wants to merge 1 commit into
Open
Conversation
…revent memory leaks and double frees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory-management issue in
json::detail::r_stringcaused by incorrect move semantics.Problem
r_stringmove operations did not safely transfer ownership in all cases, which could lead to:Root Cause
Changes
In json.h:
In test_json.cpp:
Result
- Ownership is now transferred correctly and safely in r_string.
- Leak/double-free risk paths in move-related scenarios are eliminated.
- New regression tests protect against future breakage.
Compatibility / Impact
This is an internal JSON memory-safety fix and does not change the public API. It improves runtime safety and stability.This PR fixes a memory-management issue in json::detail::r_string caused by incorrect move semantics.