fix: use unique shortnames and fail linting if duplicates are found

.github/workflows/lint-scripts.yml

@@ -44,6 +44,15 @@ jobs:
             fi
           done
 
+          dupes=$(sed -n '2p' bin/*.sh | grep -oP '(?<=^# Shortname: ).+' | sort | uniq -d)
+          if [ -n "$dupes" ]; then
+            for name in $dupes; do
+              echo "FAIL: duplicate shortname '$name' found in:"
+              grep -rl "^# Shortname: $name$" bin/*.sh | sed 's/^/  /'
+            done
+            failed=1
+          fi
+
           if [ "$failed" -eq 0 ]; then
             echo "OK: all scripts in bin/ have valid headers"
           fi

bin/Exfiltration_via_Exfiltration_Over_Alternative_Protocol.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# Shortname: data_exfiltration
+# Shortname: data_exfiltration-alternate_protocol
 # Description: Attempts to exfiltrate data using DNS dig requests that contain system data in the hostname.
 
 echo -e "\e[92mExecuting Exfiltration Over Alternative Protocol using a DNS tool sending requests to large domain names. This will take a moment to execute..." 

bin/Webserver_Bash_Reverse_Shell.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-# Shortname: data_exfiltration
+# Shortname: data_exfiltration-reverse_shell
 # Description: Attempts Command Injection to execute reverse shell.
 
 echo -e "\e[92mExecuting Command Injection to execute reverse shell."

bin/Webserver_Unexpected_Child_of_Web_Service.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
-# Shortname: data_exfiltration
+# Shortname: data_exfiltration-mysql
 # Description: Executing Command Injection to dump MySQL Server tables.
 
 echo -e "\e[92mExecuting Command Injection to dump MySQL Server tables."