fix: Search for app by name instead of using hardcoded app ID

Author: mraible

e2e/src/pages/AppCatalogPage.ts

@@ -25,29 +25,55 @@ export class AppCatalogPage extends BasePage {
     this.logger.success('App Catalog page loaded successfully');
   }
 
+  /**
+   * Search for app in catalog and navigate to its page
+   */
+  private async searchAndNavigateToApp(appName: string): Promise<void> {
+    this.logger.info(`Searching for app '${appName}' in catalog`);
+
+    await this.navigateToPath('/foundry/app-catalog', 'App catalog page');
+
+    const searchBox = this.page.getByRole('searchbox', { name: 'Search' });
+    await searchBox.fill(appName);
+    await this.page.keyboard.press('Enter');
+    await this.page.waitForLoadState('networkidle');
+
+    const appLink = this.page.getByRole('link', { name: appName, exact: true });
+
+    try {
+      await this.waiter.waitForVisible(appLink, {
+        description: `App '${appName}' link in catalog`,
+        timeout: 10000
+      });
+      this.logger.success(`Found app '${appName}' in catalog`);
+      await this.smartClick(appLink, `App '${appName}' link`);
+      await this.page.waitForLoadState('networkidle');
+    } catch (error) {
+      throw new Error(`Could not find app '${appName}' in catalog. Make sure the app is deployed.`);
+    }
+  }
+
   /**
    * Check if app is installed
    */
   async isAppInstalled(appName: string): Promise<boolean> {
     this.logger.step(`Check if app '${appName}' is installed`);
 
-    // Navigate to the app's specific catalog page first
-    const appUrl = `/foundry/app-catalog/${this.appId}`;
-    await this.navigateToPath(appUrl, `App catalog page for ${appName}`);
-    await this.page.waitForLoadState('networkidle');
+    // Search for and navigate to the app's catalog page
+    await this.searchAndNavigateToApp(appName);
 
     // Check for installation indicators on the app's page
     const installedText = this.page.locator('text=Installed').first();
-    const openButton = this.page.getByRole('button', { name: /open|launch/i });
-    const installButton = this.page.getByRole('button', { name: 'Install' });
+    const notInstalledText = this.page.locator('text=Not installed').first();
+    const installLink = this.page.getByRole('link', { name: 'Install now' });
 
     const hasInstalledText = await this.elementExists(installedText, 2000);
-    const hasOpenButton = await this.elementExists(openButton, 2000);
-    const hasInstallButton = await this.elementExists(installButton, 2000);
+    const hasNotInstalledText = await this.elementExists(notInstalledText, 2000);
+    const hasInstallLink = await this.elementExists(installLink, 2000);
 
-    // If Install button exists, app is NOT installed
-    // If Installed text or Open button exists, app IS installed
-    const isInstalled = (hasInstalledText || hasOpenButton) && !hasInstallButton;
+    // If "Not installed" text or "Install now" link exists, app is NOT installed
+    // If "Installed" text exists and no install indicators, app IS installed
+    const isInstalled = hasInstalledText && !hasNotInstalledText && !hasInstallLink;
     this.logger.info(`App '${appName}' installation status: ${isInstalled ? 'Installed' : 'Not installed'}`);
 
     return isInstalled;