fix: Improve app installation detection to check specific app page

Author: mraible

e2e/src/pages/AppCatalogPage.ts

@@ -31,14 +31,23 @@ export class AppCatalogPage extends BasePage {
   async isAppInstalled(appName: string): Promise<boolean> {
     this.logger.step(`Check if app '${appName}' is installed`);
 
-    // Try different methods to detect installation status
+    // Navigate to the app's specific catalog page first
+    const appUrl = `/foundry/app-catalog/${this.appId}`;
+    await this.navigateToPath(appUrl, `App catalog page for ${appName}`);
+    await this.page.waitForLoadState('networkidle');
+
+    // Check for installation indicators on the app's page
     const installedText = this.page.locator('text=Installed').first();
     const openButton = this.page.getByRole('button', { name: /open|launch/i });
+    const installButton = this.page.getByRole('button', { name: 'Install' });
 
     const hasInstalledText = await this.elementExists(installedText, 2000);
     const hasOpenButton = await this.elementExists(openButton, 2000);
+    const hasInstallButton = await this.elementExists(installButton, 2000);
 
-    const isInstalled = hasInstalledText || hasOpenButton;
+    // If Install button exists, app is NOT installed
+    // If Installed text or Open button exists, app IS installed
+    const isInstalled = (hasInstalledText || hasOpenButton) && !hasInstallButton;
     this.logger.info(`App '${appName}' installation status: ${isInstalled ? 'Installed' : 'Not installed'}`);
 
     return isInstalled;

e2e/tests/app-install.setup.ts

@@ -1,10 +1,7 @@
 import { test as setup } from '../src/fixtures';
 
 setup('install Functions with Python app', async ({ appCatalogPage, appName }) => {
-  // The app should already be installed - just verify it exists
-  // ServiceNow API integration will use dummy values if prompted
-  await appCatalogPage.navigateToPath('/foundry/app-catalog', 'App Catalog');
-
+  // Check if app is already installed (this navigates to the app page)
   const isInstalled = await appCatalogPage.isAppInstalled(appName);
 
   if (!isInstalled) {