Updates after testing

Author: mraible

functions/hosts-query/main.py

@@ -32,12 +32,13 @@ def on_post(request: FoundryRequest) -> FoundryResponse:
                                     object_key="event_id"
                                     )
 
-        if response.status_code != 201:
+        if response["status_code"] != 201:
+            error_message = response.get('error', {}).get('message', 'Unknown error')
             return FoundryResponse(
-                code=response.status_code,
+                code=response["status_code"],
                 errors=[FoundryAPIError(
-                    code=response.status_code,
-                    message=f"Failed to store event: {response.text}"
+                    code=response["status_code"],
+                    message=f"Failed to store event: {error_message}"
                 )]
             )
 
@@ -51,15 +52,15 @@ def on_post(request: FoundryRequest) -> FoundryResponse:
         return FoundryResponse(
             body={
                 "stored": True,
-                "record_id": response.json().get("id"),
-                "recent_events": query_response.json().get("resources", [])
+                "record_id": response["id"],
+                "recent_events": query_response.get("resources", [])
             },
             code=200
         )
     except Exception as e:
         return FoundryResponse(
             code=500,
-            errors=[FoundryAPIError(code=500, message=f"Error with collection: {str(e)}")]
+            errors=[FoundryAPIError(code=500, message=f"Error saving collection: {str(e)}")]
         )
 
 

functions/hosts-query/request_schema.json

@@ -53,24 +53,8 @@ def on_post(request: FoundryRequest, config: Dict[str, object] | None, logger: L
 
     logger.info(f"Creating ServiceNow incident with payload: {payload}")
 
-    # Call ServiceNow Table API to create incident
     try:
-        body = {
-            "resources": [{
-                "definition_id": "ServiceNow",
-                "operation_id": "POST__api_now_table_tablename",
-                "params": {
-                    "path": {
-                        "tableName": "incident",
-                    }
-                },
-                "request": {
-                    "json": payload
-                }
-            }]
-        }
-
-        # Use the APIIntegrations client to call ServiceNow
+        # Use the APIIntegrations client to call ServiceNow Table API to create incident
         api = APIIntegrations()
         response = api.execute_command_proxy(
             definition_id="ServiceNow",
@@ -93,9 +77,9 @@ def on_post(request: FoundryRequest, config: Dict[str, object] | None, logger: L
         if response["status_code"] >= 400:
             error_message = response.get('error', {}).get('message', 'Unknown error')
             return FoundryResponse(
-                code=response.status_code,
+                code=response["status_code"],
                 errors=[FoundryAPIError(
-                    code=response.status_code,
+                    code=response["status_code"],
                     message=f"ServiceNow integration error: {error_message}"
                 )]
             )

functions/hosts-query/requirements.txt

@@ -1,7 +1,7 @@
 app_id: 6ddb0b6688a345bdafaae5d5678477f3
 name: functions-python
 description: Foundry sample that shows how to use Python functions
-logo: ""
+logo: "images/logo.png"
 vendor: ""
 vendor_products: []
 use_case: Cloud security
@@ -157,31 +157,6 @@ functions:
                 - FalconPy
           permissions: []
       language: python
-    - id: 54320438ff5642bfb54d12edb18fceff
-      name: hosts-query
-      config: null
-      description: Query a Host with Good Logging
-      path: functions/hosts-query
-      environment_variables: {}
-      handlers:
-        - name: hosts-query
-          description: Query a Host with Good Logging
-          method: POST
-          api_path: /hosts-query
-          payload_type: ""
-          request_schema: request_schema.json
-          response_schema: response_schema.json
-          workflow_integration:
-            id: f1f261a5815549d48489d4af0d9a52a7
-            disruptive: false
-            system_action: true
-            tags:
-                - 6ddb0b6688a345bdafaae5d5678477f3
-                - Functions
-                - Logging
-                - FalconPy
-          permissions: []
-      language: python
     - id: 86c21f8136204c30bcddccfab707d939
       name: host-info
       config: null