Skip to content

Commit b69450b

Browse files
Use Max-Age casing in browserHandler for consistency
The other three request handlers write Max-Age; the browser handler was the odd one out with lowercase max-age. Cookie attributes are case-insensitive so this is cosmetic, but keeps the SDK output uniform. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0c3fd17 commit b69450b

10 files changed

Lines changed: 20 additions & 20 deletions

dist/crowdhandler.cjs.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/crowdhandler.cjs.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/crowdhandler.esm.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/crowdhandler.esm.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/crowdhandler.umd.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/crowdhandler.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/crowdhandler.umd.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/crowdhandler.umd.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/request/browserHandler.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ var BrowserHandler = /** @class */ (function () {
3535
cookieOptions.domain = domain;
3636
}
3737
// Opt-in persistence — when maxAgeSeconds is omitted, the cookie is a
38-
// session cookie (browsers drop it when closed). max-age is preferred
39-
// over expires because it's not affected by client clock skew.
38+
// session cookie (browsers drop it when closed). Max-Age is preferred
39+
// over Expires because it's not affected by client clock skew.
4040
if (maxAgeSeconds) {
41-
cookieOptions["max-age"] = maxAgeSeconds;
41+
cookieOptions["Max-Age"] = maxAgeSeconds;
4242
}
4343
document.cookie = "".concat(cookieName, "=").concat(value, "; ").concat(Object.keys(cookieOptions)
4444
.map(function (key) { return "".concat(key, "=").concat(cookieOptions[key]); })

src/request/browserHandler.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ export class BrowserHandler {
3737
}
3838

3939
// Opt-in persistence — when maxAgeSeconds is omitted, the cookie is a
40-
// session cookie (browsers drop it when closed). max-age is preferred
41-
// over expires because it's not affected by client clock skew.
40+
// session cookie (browsers drop it when closed). Max-Age is preferred
41+
// over Expires because it's not affected by client clock skew.
4242
if (maxAgeSeconds) {
43-
cookieOptions["max-age"] = maxAgeSeconds;
43+
cookieOptions["Max-Age"] = maxAgeSeconds;
4444
}
4545

4646
document.cookie = `${cookieName}=${value}; ${Object.keys(cookieOptions)

0 commit comments

Comments
 (0)