Merge pull request #15 from Crowdhandler/fix/recordPerformance-php-warning

carl-wells-crowdhandler · web-flow · commit 3c5eec39e126 · 2022-12-23T10:16:00.000Z
Added a check only run recordPerformance when a response is available
diff --git a/src/GateKeeper.php b/src/GateKeeper.php
@@ -288,7 +288,7 @@ private function setCookie($cookie)
      */
     public function recordPerformance($httpCode=200)
     {   
-        if(property_exists($this->result, 'responseID')) {
+        if(isset($this->result) && property_exists($this->result, 'responseID')) {
             $time = $this->timer->elapsed();
             $this->client->responses->put($this->result->responseID, array('code'=>$httpCode, 'time'=>$time));
             $this->debug('Page performance was recorded '.$time);

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ private function setCookie($cookie)`
`288`	`288`	`*/`
`289`	`289`	`public function recordPerformance($httpCode=200)`
`290`	`290`	`{`
`291`		`- if(property_exists($this->result, 'responseID')) {`
	`291`	`+ if(isset($this->result) && property_exists($this->result, 'responseID')) {`
`292`	`292`	`$time = $this->timer->elapsed();`
`293`	`293`	`$this->client->responses->put($this->result->responseID, array('code'=>$httpCode, 'time'=>$time));`
`294`	`294`	`$this->debug('Page performance was recorded '.$time);`