Skip to content

Commit 0758049

Browse files
committed
Rename onClick param for easier readability and remove unused imports
1 parent 700c206 commit 0758049

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

app/src/main/kotlin/org/cru/godtools/ui/dashboard/lessons/LessonsLayout.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ internal fun LessonsLayout(state: UiState, modifier: Modifier = Modifier) {
7575
if (state.mode == UiState.Mode.PERSONALIZATION && state.dataLoaded && state.lessons.isEmpty()) {
7676
item("no-personalized-lessons", "no-personalized-lessons") {
7777
NoPersonalizedLessons(
78-
onClick = { state.eventSink(UiEvent.ChangeMode(UiState.Mode.ALL_LESSONS)) },
78+
onGoToAllLessons = { state.eventSink(UiEvent.ChangeMode(UiState.Mode.ALL_LESSONS)) },
7979
modifier = Modifier.padding(top = 16.dp, horizontal = MARGIN_LESSONS_LAYOUT_HORIZONTAL)
8080
)
8181
}

app/src/main/kotlin/org/cru/godtools/ui/dashboard/lessons/NoPersonalizedLessons.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import androidx.compose.foundation.layout.fillMaxWidth
55
import androidx.compose.foundation.layout.padding
66
import androidx.compose.foundation.layout.size
77
import androidx.compose.material.icons.Icons
8-
import androidx.compose.material.icons.outlined.ErrorOutline
98
import androidx.compose.material.icons.outlined.PriorityHigh
109
import androidx.compose.material3.Button
1110
import androidx.compose.material3.Icon
@@ -21,7 +20,7 @@ import androidx.compose.ui.unit.dp
2120
import org.cru.godtools.R
2221

2322
@Composable
24-
internal fun NoPersonalizedLessons(onClick: () -> Unit, modifier: Modifier = Modifier) {
23+
internal fun NoPersonalizedLessons(onGoToAllLessons: () -> Unit, modifier: Modifier = Modifier) {
2524
Surface(
2625
color = MaterialTheme.colorScheme.surfaceVariant,
2726
modifier = modifier.fillMaxWidth(),
@@ -48,7 +47,7 @@ internal fun NoPersonalizedLessons(onClick: () -> Unit, modifier: Modifier = Mod
4847
modifier = Modifier.padding(top = 8.dp),
4948
)
5049
Button(
51-
onClick = onClick,
50+
onClick = onGoToAllLessons,
5251
modifier = Modifier.padding(top = 16.dp),
5352
) {
5453
Text(stringResource(R.string.dashboard_lessons_section_personalized_no_lessons_button))

0 commit comments

Comments
 (0)