Use typed DataBinding property setters instead of setVariable(BR.xxx) in OtherActionsAdapter

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: frett

ui/base-tool/src/main/kotlin/org/cru/godtools/base/tool/ui/share/OtherActionsAdapter.kt

@@ -7,7 +7,6 @@ import androidx.databinding.ViewDataBinding
 import androidx.lifecycle.LifecycleOwner
 import org.ccci.gto.android.common.androidx.recyclerview.adapter.SimpleDataBindingAdapter
 import org.cru.godtools.base.tool.ui.share.model.ShareItem
-import org.cru.godtools.tool.BR
 
 class OtherActionsAdapter(
     lifecycleOwner: LifecycleOwner,
@@ -24,11 +23,9 @@ class OtherActionsAdapter(
     override fun getItemViewType(position: Int) = items[position].actionLayout!!
 
     override fun onCreateViewDataBinding(parent: ViewGroup, viewType: Int): ViewDataBinding =
-        DataBindingUtil.inflate<ViewDataBinding?>(LayoutInflater.from(parent.context), viewType, parent, false).also {
-            it.setVariable(BR.callbacks, callbacks)
-        }
+        DataBindingUtil.inflate<ViewDataBinding?>(LayoutInflater.from(parent.context), viewType, parent, false)
 
     override fun onBindViewDataBinding(binding: ViewDataBinding, position: Int) {
-        binding.setVariable(BR.item, items[position])
+        items[position].bindTo(binding, callbacks)
     }
 }

ui/base-tool/src/main/kotlin/org/cru/godtools/base/tool/ui/share/model/ShareItem.kt

@@ -4,7 +4,9 @@ import android.app.Activity
 import android.content.Intent
 import android.os.Parcelable
 import androidx.annotation.LayoutRes
+import androidx.databinding.ViewDataBinding
 import org.ccci.gto.android.common.base.Ordered
+import org.cru.godtools.base.tool.ui.share.OtherActionsAdapter.Callbacks
 
 interface ShareItem :
     Parcelable,
@@ -13,6 +15,7 @@ interface ShareItem :
 
     @get:LayoutRes
     val actionLayout: Int? get() = null
+    fun bindTo(binding: ViewDataBinding, callbacks: Callbacks?) = Unit
     fun triggerAction(activity: Activity)
 
     val isValid get() = true

ui/base-tool/src/main/kotlin/org/cru/godtools/base/tool/ui/shareable/model/ShareableImageShareItem.kt

@@ -3,6 +3,7 @@ package org.cru.godtools.base.tool.ui.shareable.model
 import android.app.Activity
 import android.content.Context
 import android.content.Intent
+import androidx.databinding.ViewDataBinding
 import androidx.fragment.app.FragmentActivity
 import dagger.assisted.Assisted
 import dagger.assisted.AssistedFactory
@@ -16,10 +17,12 @@ import org.ccci.gto.android.common.base.Ordered
 import org.cru.godtools.base.ToolFileSystem
 import org.cru.godtools.base.tool.model.getFileBlocking
 import org.cru.godtools.base.tool.model.shareable.buildShareIntent
+import org.cru.godtools.base.tool.ui.share.OtherActionsAdapter
 import org.cru.godtools.base.tool.ui.share.model.ShareItem
 import org.cru.godtools.base.tool.ui.shareable.ShareableImageBottomSheetDialogFragment
 import org.cru.godtools.shared.tool.parser.model.shareable.ShareableImage
 import org.cru.godtools.tool.R
+import org.cru.godtools.tool.databinding.ToolShareItemShareableImageBinding
 
 @Parcelize
 class ShareableImageShareItem(
@@ -48,6 +51,11 @@ class ShareableImageShareItem(
     }
 
     override val actionLayout get() = R.layout.tool_share_item_shareable_image
+    override fun bindTo(binding: ViewDataBinding, callbacks: OtherActionsAdapter.Callbacks?) {
+        require(binding is ToolShareItemShareableImageBinding)
+        binding.callbacks = callbacks
+        binding.item = this
+    }
 
     override val order get() = Ordered.LOWEST_PRECEDENCE
 

ui/tract-renderer/src/main/kotlin/org/cru/godtools/tract/ui/share/model/LiveShareItem.kt

@@ -1,14 +1,22 @@
 package org.cru.godtools.tract.ui.share.model
 
 import android.app.Activity
+import androidx.databinding.ViewDataBinding
 import kotlinx.parcelize.Parcelize
+import org.cru.godtools.base.tool.ui.share.OtherActionsAdapter
 import org.cru.godtools.base.tool.ui.share.model.ShareItem
 import org.cru.godtools.tool.tract.R
+import org.cru.godtools.tool.tract.databinding.TractShareItemLiveShareBinding
 import org.cru.godtools.tract.activity.TractActivity
 
 @Parcelize
 class LiveShareItem : ShareItem {
     override val actionLayout get() = R.layout.tract_share_item_live_share
+    override fun bindTo(binding: ViewDataBinding, callbacks: OtherActionsAdapter.Callbacks?) {
+        require(binding is TractShareItemLiveShareBinding)
+        binding.callbacks = callbacks
+        binding.item = this
+    }
 
     override fun triggerAction(activity: Activity) {
         (activity as? TractActivity)?.showLiveShareTutorial()