Skip to content

Commit 84f2085

Browse files
frettclaude
andcommitted
Dismiss MutableState-in-UiState PR review finding
Circuit only requires UiState to be @stable, not strictly immutable. Embedding MutableState<T> fields is valid when the type is stable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 47f6903 commit 84f2085

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.claude/skills/pr-review/dismissed-issues.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,9 @@
33
Issues listed here are suppressed in future PR reviews.
44

55
---
6+
7+
## MutableState in UiState
8+
**Pattern**: Flagging `MutableState<T>` (or other Compose `State<T>` objects) as fields in a Circuit `UiState` data class as an architectural violation.
9+
**Reason**: Circuit only requires `UiState` to be `@Stable`, not strictly immutable. Embedding `MutableState<T>` (which is stable) is valid and intentional — it allows the UI to mutate local state (e.g. search query) without routing every keystroke through `eventSink`.
10+
**Dismissed**: 2026-03-30
11+
**Dismissed by**: Daniel Frett

0 commit comments

Comments
 (0)