Skip to content

GT-3008 Currently Selected Country At Top Of List#4388

Merged
tjohnson009 merged 8 commits into
developfrom
GT-3008-Current_selected_Country-Top
Apr 14, 2026
Merged

GT-3008 Currently Selected Country At Top Of List#4388
tjohnson009 merged 8 commits into
developfrom
GT-3008-Current_selected_Country-Top

Conversation

@tjohnson009

Copy link
Copy Markdown
Contributor
  • Add selectedCountry to top of countries list - no overlay when clicked
  • Record updated snapshots

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.70%. Comparing base (bfc58d2) to head (3dffbc3).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/ui/languages/country/CountrySettingsPresenter.kt 0.00% 5 Missing ⚠️
...ools/ui/languages/country/CountrySettingsLayout.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4388   +/-   ##
========================================
  Coverage    50.70%   50.70%           
========================================
  Files          445      445           
  Lines        12000    12000           
  Branches      2079     2080    +1     
========================================
  Hits          6084     6084           
  Misses        5300     5300           
  Partials       616      616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frett

frett commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

@tjohnson009 you could update the layout tests to have the selected one first in the data you provide, but I'm honestly not worried about that. The main thing the paparazzi tests are meant to do is detect unexpected rendering changes, the actual data it's rendering is meaningless. So having the checkmark visible on 1 row is enough for the test.

Testing the order of the countries to reflect the currently selected country coming first is the responsibility of a presenter test for this

@tjohnson009 tjohnson009 merged commit a6f8623 into develop Apr 14, 2026
13 checks passed
@tjohnson009 tjohnson009 deleted the GT-3008-Current_selected_Country-Top branch April 14, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants