Restructure settings UI package hierarchy

[frett]

Summary

• Moves all settings-related UI from ui/languages/* into a cleaner package hierarchy under ui/settings/
• Moves shared language name composables (LanguageName, LocalizedName) to ui/common
• Removes unused LanguageSettingsViewModel
• Updates Paparazzi snapshot paths to match new packages

New package layout

Old	New
ui/languages/downloadable/	ui/settings/language/downloadable/
ui/languages/ (LanguageSettings)	ui/settings/language/
ui/languages/app/	ui/settings/language/app/
ui/languages/country/	ui/settings/country/
ui/languages/LanguageName	ui/common/

Test plan

• Paparazzi snapshots recorded and folded into each commit via CI
• Verify app builds and navigates to language/country settings correctly

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.20%. Comparing base (b6eca20) to head (8639474).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4403      +/-   ##
===========================================
+ Coverage    51.16%   51.20%   +0.04%     
===========================================
  Files          446      445       -1     
  Lines        12009    11994      -15     
  Branches      2086     2084       -2     
===========================================
- Hits          6144     6142       -2     
+ Misses        5242     5230      -12     
+ Partials       623      622       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[frett]

PR Review: Restructure settings UI package hierarchy (#4403)

Summary

Reorganizes settings-related UI from ui/languages/* into semantically cleaner packages (ui/settings/language/*, ui/settings/country/*, ui/common/*), removes the unused LanguageSettingsViewModel, migrates ImmutableList → List in affected UiState types, and fixes UiEvent to be sealed interface.

Checklist Findings

✅ Looks Good

• ktlint passes
• Package naming is semantically correct and consistent throughout
• LanguageSettingsViewModel deleted; no remaining usages
• UiEvent is now sealed interface in LanguageSettingsPresenter (convention met)
• ImmutableList → List in LanguageSettingsPresenter.UiState, AppLanguagePresenter.UiState, CountrySettingsPresenter.UiState, DownloadableLanguagesScreen.UiState (all cleaned up)
• All Circuit patterns intact: @AssistedInject, @CircuitInject, nested UiState/UiEvent, eventSink delegation
• GodToolsTheme used throughout; no per-module themes introduced
• Paparazzi snapshot images renamed to match new package paths
• Presenter tests (LanguageSettingsPresenterTest, AppLanguagePresenterTest, DownloadableLanguagesPresenterTest) correctly moved from testDebug → test
• All presenter tests use presenter.test { } (Circuit test API)
• LanguageName import correctly added to LanguageSettingsLayout.kt after package separation
• No build script changes; no new dependencies

Overall Verdict

APPROVE — Clean structural reorganization with no functional changes. All convention items pass.

🤖 Reviewed with Claude Code