Skip to content

GT-3017 Onboarding Localization#4405

Merged
tjohnson009 merged 21 commits into
developfrom
GT-3017-Onboarding-Localization
May 5, 2026
Merged

GT-3017 Onboarding Localization#4405
tjohnson009 merged 21 commits into
developfrom
GT-3017-Onboarding-Localization

Conversation

@tjohnson009

Copy link
Copy Markdown
Contributor
  • Add pop result to app language screen to track result
  • Modify popResult names and add for presenter
  • Add pop result to navigator.pop in UiEvents
  • Modify tests to reflect newly added pop result
  • Add result interface for pop results to send to presenter
  • Receive newly added pop results in UiEvents
  • Sync pager to presenter page state via LaunchedEffect and disable swipe on welcome
  • Add answering navigators and Next event for language/country flow in presenter
  • Add initial state and Next event tests to OnboardingPresenterTest
  • Change event passed to prevent block from continue onboarding
  • Change test to pass with the previous dismiss select language event blocking onboarding

Comment thread app/src/main/kotlin/org/cru/godtools/ui/onboarding/OnboardingLayout.kt Outdated
Comment thread app/src/main/kotlin/org/cru/godtools/ui/onboarding/OnboardingPresenter.kt Outdated
@tjohnson009 tjohnson009 force-pushed the GT-3017-Onboarding-Localization branch from b4e039e to 4d107ac Compare April 29, 2026 21:07
@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.63636% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.02%. Comparing base (d10b5c0) to head (247fa4c).
⚠️ Report is 27 commits behind head on develop.

Files with missing lines Patch % Lines
.../cru/godtools/ui/onboarding/OnboardingPresenter.kt 46.66% 12 Missing and 4 partials ⚠️
...org/cru/godtools/ui/onboarding/OnboardingLayout.kt 0.00% 5 Missing ⚠️
...ls/ui/settings/country/CountrySettingsPresenter.kt 0.00% 2 Missing ⚠️
...tools/ui/settings/country/CountrySettingsScreen.kt 0.00% 2 Missing ⚠️
...dtools/base/ui/circuit/screen/AppLanguageScreen.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4405      +/-   ##
===========================================
- Coverage    51.20%   51.02%   -0.19%     
===========================================
  Files          445      449       +4     
  Lines        11994    12107     +113     
  Branches      2084     2100      +16     
===========================================
+ Hits          6142     6177      +35     
- Misses        5230     5315      +85     
+ Partials       622      615       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tjohnson009 tjohnson009 requested a review from frett May 1, 2026 13:01
Comment thread app/src/main/kotlin/org/cru/godtools/ui/onboarding/OnboardingPresenter.kt Outdated
Comment thread app/src/main/kotlin/org/cru/godtools/ui/onboarding/OnboardingPresenter.kt Outdated
Comment thread app/src/main/kotlin/org/cru/godtools/ui/onboarding/OnboardingPresenter.kt Outdated
Comment thread app/src/main/kotlin/org/cru/godtools/ui/onboarding/OnboardingPresenter.kt Outdated
Comment thread app/src/main/kotlin/org/cru/godtools/ui/onboarding/OnboardingPresenter.kt Outdated
@tjohnson009 tjohnson009 merged commit 1536e64 into develop May 5, 2026
13 checks passed
@tjohnson009 tjohnson009 deleted the GT-3017-Onboarding-Localization branch May 5, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants