GT-3017 Onboarding Localization#4405
Merged
Merged
Conversation
tjohnson009
commented
Apr 27, 2026
Contributor
- Add pop result to app language screen to track result
- Modify popResult names and add for presenter
- Add pop result to navigator.pop in UiEvents
- Modify tests to reflect newly added pop result
- Add result interface for pop results to send to presenter
- Receive newly added pop results in UiEvents
- Sync pager to presenter page state via LaunchedEffect and disable swipe on welcome
- Add answering navigators and Next event for language/country flow in presenter
- Add initial state and Next event tests to OnboardingPresenterTest
- Change event passed to prevent block from continue onboarding
- Change test to pass with the previous dismiss select language event blocking onboarding
frett
reviewed
Apr 27, 2026
frett
reviewed
Apr 27, 2026
frett
reviewed
Apr 27, 2026
frett
reviewed
Apr 27, 2026
…locking onboarding
…nd app language screens
b4e039e to
4d107ac
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4405 +/- ##
===========================================
- Coverage 51.20% 51.02% -0.19%
===========================================
Files 445 449 +4
Lines 11994 12107 +113
Branches 2084 2100 +16
===========================================
+ Hits 6142 6177 +35
- Misses 5230 5315 +85
+ Partials 622 615 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frett
reviewed
May 1, 2026
frett
reviewed
May 1, 2026
…nd countrySettings flag
frett
reviewed
May 4, 2026
frett
reviewed
May 4, 2026
frett
reviewed
May 4, 2026
frett
reviewed
May 5, 2026
frett
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.