Skip to content

Refactor ToolCard event types and introduce ToolCardPresenter interface #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frett merged 4 commits into from
May 5, 2026

Introduce ToolCardEvent sealed interface for card-level UiEvents

f437d3a
Select commit
Loading
Failed to load commit list.
Merged

Refactor ToolCard event types and introduce ToolCardPresenter interface #4410

Introduce ToolCardEvent sealed interface for card-level UiEvents
f437d3a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 5, 2026 in 1s

51.52% (+0.05%) compared to 1536e64

View this Pull Request on Codecov

51.52% (+0.05%) compared to 1536e64

Details

Codecov Report

❌ Patch coverage is 84.84848% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.52%. Comparing base (1536e64) to head (f437d3a).

Files with missing lines Patch % Lines
.../cru/godtools/ui/tools/DefaultToolCardPresenter.kt 92.30% 0 Missing and 7 partials ⚠️
.../cru/godtools/ui/dashboard/tools/ToolsPresenter.kt 40.00% 4 Missing and 2 partials ⚠️
.../godtools/ui/dashboard/lessons/LessonsPresenter.kt 60.00% 1 Missing and 1 partial ⚠️
...in/org/cru/godtools/ui/tools/ToolCardComponents.kt 33.33% 0 Missing and 2 partials ⚠️
...odtools/ui/dashboard/home/AllFavoritesPresenter.kt 80.00% 0 Missing and 1 partial ⚠️
...rg/cru/godtools/ui/dashboard/home/HomePresenter.kt 87.50% 0 Missing and 1 partial ⚠️
...org/cru/godtools/ui/dashboard/tools/ToolsLayout.kt 0.00% 0 Missing and 1 partial ⚠️
...ru/godtools/ui/tooldetails/ToolDetailsPresenter.kt 50.00% 0 Missing and 1 partial ⚠️
...kotlin/org/cru/godtools/ui/tools/FavoriteAction.kt 75.00% 0 Missing and 1 partial ⚠️
...kotlin/org/cru/godtools/ui/tools/SquareToolCard.kt 66.66% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4410      +/-   ##
===========================================
+ Coverage    51.47%   51.52%   +0.05%     
===========================================
  Files          449      451       +2     
  Lines        11992    11976      -16     
  Branches      2086     2066      -20     
===========================================
- Hits          6173     6171       -2     
+ Misses        5203     5194       -9     
+ Partials       616      611       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov