Consolidate dashboard Paparazzi tests into DashboardLayoutPaparazziTest

[frett]

Summary

• Folds all dashboard page Paparazzi tests (HomeLayout, AllFavoritesLayout, ToolsLayout, LessonsLayout) into DashboardLayoutPaparazziTest so each page is snapshotted rendered within the full dashboard shell (nav bar, scaffold, top app bar) rather than standalone
• Moves the open nav drawer snapshot from DrawerMenuLayoutPaparazziTest into DashboardLayoutPaparazziTest so the drawer is shown in context of the full dashboard
• Adds a locale parameter (null / in) to DashboardLayoutPaparazziTest; tests that are locale-specific (Lessons, select Tools modes) run both variants, others skip non-null locale via assumeTrue

Test plan

• ./gradlew verifyPaparazzi passes

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.75%. Comparing base (62f1cff) to head (3dc2f92).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4415      +/-   ##
===========================================
+ Coverage    51.67%   51.75%   +0.08%     
===========================================
  Files          453      453              
  Lines        12014    12014              
  Branches      2079     2079              
===========================================
+ Hits          6208     6218      +10     
+ Misses        5191     5181      -10     
  Partials       615      615              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[frett]

PR Review: Consolidate dashboard Paparazzi tests into DashboardLayoutPaparazziTest (#4415)

Summary

Moves all standalone dashboard page Paparazzi tests (HomeLayout, AllFavoritesLayout, ToolsLayout, LessonsLayout, DrawerMenuLayout) into a single DashboardLayoutPaparazziTest, rendering each through the full dashboard shell (nav bar, scaffold, top app bar) rather than in isolation. Adds a locale parameter to enable locale variants on selected tests.

Checklist Findings

✅ Looks Good

• ktlint — passes cleanly, no violations
• BasePaparazziTest convention — DashboardLayoutPaparazziTest correctly extends BasePaparazziTest with the full @TestParameter night/accessibility/device matrix
• Snapshots via CI — no locally-recorded snapshots; all PNG changes are LFS pointers committed by the CI workflow
• Circuit wiring — presenterOf { stateVar } pattern correctly captures the mutable state var at composition time, consistent with the existing toolsState usage
• State mutability — var used only where tests mutate the state (homeState, toolsState); val elsewhere (lessonsState, allFavoritesState) — appropriate
• Locale scoping — LessonsLayout() and the two ToolsLayout() modes correctly run both locale variants; other tests use assumeTrue(locale == null) to preserve original coverage scope
• DrawerMenuScreenStateTestData — drawer test correctly uses the existing test utility (with versionName/versionCode populated) rather than constructing DrawerState manually
• Deleted test files — all four standalone test classes cleanly removed with no orphaned snapshot files

⚠️ Minor Issues

(none)

❌ Must Fix

(none)

Overall Verdict

APPROVE — Clean, focused refactoring with no convention violations. Every deleted test is accounted for in the consolidated class, snapshot coverage is preserved or expanded, and the CI workflow correctly generated all new reference images.