GT-2980 No Personalized Lessons UI#4430
Conversation
tjohnson009
commented
May 26, 2026
- Add dataLoaded flag to delay rendering; Add string resources
- Create and add NoPersonalizedLessons UI
- Modify exclamation icon for NoPersonalizedLessons composable
- Rename onClick param for easier readability and remove unused imports
- Swap icon to more closely reflect Figma design
- Add closer matching icon for NoPersonalizedLessons composable
98ae0a7 to
089ff26
Compare
|
@tjohnson009 you're going to have to clean up the merge conflicts on this |
0d139d9 to
2ef35c2
Compare
frett
left a comment
There was a problem hiding this comment.
a couple minor comments, I also want to make sure we have screenshot tests of this UI if they don't already exist
|
It seems that the NoPersonalizedLessons UI will be covered by a test that is already present in the test suite. Unless we want one for that UI element specifically when I rerecord the screenshots it should be covered as well. |
|
Or actually I could add some lessons so that the localization settings box shows with some lessons present as opposed to always with the no personalized lessons UI |
7fb5700 to
abbf682
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4430 +/- ##
===========================================
+ Coverage 52.24% 52.34% +0.10%
===========================================
Files 457 458 +1
Lines 12170 12228 +58
Branches 2109 2123 +14
===========================================
+ Hits 6358 6401 +43
- Misses 5192 5202 +10
- Partials 620 625 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a95889e to
767eb21
Compare
frett
left a comment
There was a problem hiding this comment.
just one minor comment about something that might convey meaning better, and the behavior question I posted in Slack.
767eb21 to
a28310d
Compare