Skip to content

GT-2980 No Personalized Lessons UI#4430

Merged
tjohnson009 merged 10 commits into
developfrom
GT-2980-No-Lessons-UI
Jun 1, 2026
Merged

GT-2980 No Personalized Lessons UI#4430
tjohnson009 merged 10 commits into
developfrom
GT-2980-No-Lessons-UI

Conversation

@tjohnson009

Copy link
Copy Markdown
Contributor
  • Add dataLoaded flag to delay rendering; Add string resources
  • Create and add NoPersonalizedLessons UI
  • Modify exclamation icon for NoPersonalizedLessons composable
  • Rename onClick param for easier readability and remove unused imports
  • Swap icon to more closely reflect Figma design
  • Add closer matching icon for NoPersonalizedLessons composable

@tjohnson009 tjohnson009 requested a review from frett May 26, 2026 16:20
@frett frett force-pushed the GT-2990-Localization-Settings-Box branch from 98ae0a7 to 089ff26 Compare May 26, 2026 17:30
Base automatically changed from GT-2990-Localization-Settings-Box to develop May 26, 2026 19:58
@frett

frett commented May 26, 2026

Copy link
Copy Markdown
Contributor

@tjohnson009 you're going to have to clean up the merge conflicts on this

Comment thread app/src/main/kotlin/org/cru/godtools/ui/dashboard/tools/ToolsLayout.kt Outdated
Comment thread app/src/main/kotlin/org/cru/godtools/ui/dashboard/PinLastItemBottomArrangement.kt Outdated
@tjohnson009 tjohnson009 force-pushed the GT-2980-No-Lessons-UI branch from 0d139d9 to 2ef35c2 Compare May 27, 2026 21:04
Comment thread app/src/main/res/drawable/ic_priority_high.xml Outdated

@frett frett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple minor comments, I also want to make sure we have screenshot tests of this UI if they don't already exist

@tjohnson009

Copy link
Copy Markdown
Contributor Author

It seems that the NoPersonalizedLessons UI will be covered by a test that is already present in the test suite. Unless we want one for that UI element specifically when I rerecord the screenshots it should be covered as well.

@tjohnson009

Copy link
Copy Markdown
Contributor Author

Or actually I could add some lessons so that the localization settings box shows with some lessons present as opposed to always with the no personalized lessons UI

@tjohnson009 tjohnson009 force-pushed the GT-2980-No-Lessons-UI branch from 7fb5700 to abbf682 Compare May 29, 2026 13:38
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.34%. Comparing base (e91de5a) to head (a28310d).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
.../godtools/ui/dashboard/lessons/LessonsPresenter.kt 71.42% 0 Missing and 2 partials ⚠️
...cru/godtools/ui/dashboard/lessons/LessonsLayout.kt 80.00% 0 Missing and 1 partial ⚠️
...ools/ui/dashboard/lessons/NoPersonalizedLessons.kt 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4430      +/-   ##
===========================================
+ Coverage    52.24%   52.34%   +0.10%     
===========================================
  Files          457      458       +1     
  Lines        12170    12228      +58     
  Branches      2109     2123      +14     
===========================================
+ Hits          6358     6401      +43     
- Misses        5192     5202      +10     
- Partials       620      625       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tjohnson009 tjohnson009 force-pushed the GT-2980-No-Lessons-UI branch from a95889e to 767eb21 Compare May 29, 2026 18:58

@frett frett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor comment about something that might convey meaning better, and the behavior question I posted in Slack.

@tjohnson009 tjohnson009 force-pushed the GT-2980-No-Lessons-UI branch from 767eb21 to a28310d Compare May 29, 2026 20:42
@tjohnson009 tjohnson009 merged commit e49584e into develop Jun 1, 2026
21 checks passed
@tjohnson009 tjohnson009 deleted the GT-2980-No-Lessons-UI branch June 1, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants