MPDX-9617 Fix Credit Card Fees formula percent precision in PDS Goal Calculator (#1796)

* Fix Credit Card Fees formula percent precision in PDS Goal Calculator

Author: wjames111

.claude/rules/code-review.md

@@ -130,12 +130,13 @@ MPDX displays and calculates donation/partner-giving aggregations across dozens
 **Trigger conditions:**
 
 - Any file under `src/components/Reports/**`
-- Any file under `src/components/Reports/GoalCalculator/**` or `src/components/Reports/PdsGoalCalculator/**`
-- Any file under `src/components/Reports/SalaryCalculator/**`
+- Any file under `src/components/HrTools/**`
+- Any file under `src/components/Reports/GoalCalculator/**`, `src/components/HrTools/GoalCalculator/**`, or `src/components/HrTools/PdsGoalCalculator/**`
+- Any file under `src/components/Reports/SalaryCalculator/**` or `src/components/HrTools/SalaryCalculator/**`
 - Any file under `src/components/EditDonationModal/**`
-- Any file under `src/components/Reports/AdditionalSalaryRequest/**`, `src/components/Reports/MinisterHousingAllowance/**`
+- Any file under `src/components/Reports/AdditionalSalaryRequest/**`, `src/components/HrTools/AdditionalSalaryRequest/**`, or `src/components/HrTools/MinisterHousingAllowance/**`
 - Any file under `src/components/Dashboard/MonthlyGoal/**`, `src/components/Dashboard/DonationHistories/**`
-- Diff content contains any of: `amount`, `currency`, `convertedAmount`, `pledgeAmount`, `goal`, `balance`, `total`, `sum(`, `reduce((`, `.toFixed(`, `Math.round(`, `Number(`, `parseFloat(`, `parseInt(` inside `src/components/Reports/**` or goal/donation components
+- Diff content contains any of: `amount`, `currency`, `convertedAmount`, `pledgeAmount`, `goal`, `balance`, `total`, `sum(`, `reduce((`, `.toFixed(`, `Math.round(`, `Number(`, `parseFloat(`, `parseInt(` inside `src/components/Reports/**`, `src/components/HrTools/**`, or other goal/donation components
 
 **Focus areas:**
 

src/components/HrTools/PdsGoalCalculator/SupportItem/otherBreakdown.test.tsx

@@ -157,6 +157,51 @@ describe('buildOtherBreakdownRows', () => {
     ]);
   });
 
+  it('renders the credit-card-fees formula with the configured fee rate, not a rounded percent', () => {
+    const fractionalRateConstants: OtherExpensesConstants = {
+      ...constants,
+      creditCardFeeRate: 0.006,
+    };
+
+    const rows = buildOtherBreakdownRows(
+      fullTimeCalculation,
+      fractionalRateConstants,
+      'en-US',
+      i18n.t,
+    );
+
+    const creditCardFees = rows.find((row) => row.id === 'credit-card-fees');
+    expect(creditCardFees?.formula).toBe(
+      '(Subtotal + Attrition) ÷ (1 - 0.60%) - (Subtotal + Attrition)',
+    );
+  });
+
+  it('renders the attrition formula with the rate as a decimal value', () => {
+    const rows = buildOtherBreakdownRows(
+      fullTimeCalculation,
+      { ...constants, attritionRate: 0.06 },
+      'en-US',
+      i18n.t,
+    );
+
+    const attrition = rows.find((row) => row.id === 'attrition');
+    expect(attrition?.formula).toBe('Subtotal × 0.06%');
+  });
+
+  it('renders the assessment formula with the admin rate as a decimal value', () => {
+    const rows = buildOtherBreakdownRows(
+      fullTimeCalculation,
+      { ...constants, adminRate: 0.12 },
+      'en-US',
+      i18n.t,
+    );
+
+    const assessment = rows.find((row) => row.id === 'assessment');
+    expect(assessment?.formula).toBe(
+      '(Subtotal + Attrition + Credit Card Fees) ÷ (1 − 0.12%) − (Subtotal + Attrition + Credit Card Fees)',
+    );
+  });
+
   it('uses a subtotal formula without reimbursable/403b in Simple form', () => {
     const simpleCalculation: OtherExpensesFields = {
       ...fullTimeCalculation,

src/components/HrTools/PdsGoalCalculator/SupportItem/otherBreakdown.tsx

@@ -7,7 +7,11 @@ import {
   DesignationSupportFormType,
   DesignationSupportStatus,
 } from 'src/graphql/types.generated';
-import { currencyFormat, percentageFormat } from 'src/lib/intlFormat';
+import {
+  currencyFormat,
+  numberFormat,
+  percentageFormat,
+} from 'src/lib/intlFormat';
 import {
   OtherExpensesConstants,
   OtherExpensesFields,
@@ -106,8 +110,11 @@ export const buildOtherBreakdownRows = (
     {
       id: 'attrition',
       category: t('Attrition'),
-      formula: t('Subtotal × {{rate}}', {
-        rate: percentageFormat(constants.attritionRate, locale),
+      formula: t('Subtotal × {{rate}}%', {
+        rate: numberFormat(constants.attritionRate, locale, {
+          minimumFractionDigits: 2,
+          maximumFractionDigits: 4,
+        }),
       }),
       amount: totals.attrition,
       testId: 'other-attrition',
@@ -119,7 +126,9 @@ export const buildOtherBreakdownRows = (
       formula: t(
         '(Subtotal + Attrition) ÷ (1 - {{rate}}) - (Subtotal + Attrition)',
         {
-          rate: percentageFormat(constants.creditCardFeeRate, locale),
+          rate: percentageFormat(constants.creditCardFeeRate, locale, {
+            fractionDigits: 2,
+          }),
         },
       ),
       amount: totals.creditCardFees,
@@ -130,9 +139,12 @@ export const buildOtherBreakdownRows = (
       id: 'assessment',
       category: t('Assessment'),
       formula: t(
-        '(Subtotal + Attrition + Credit Card Fees) ÷ (1 − {{rate}}) − (Subtotal + Attrition + Credit Card Fees)',
+        '(Subtotal + Attrition + Credit Card Fees) ÷ (1 − {{rate}}%) − (Subtotal + Attrition + Credit Card Fees)',
         {
-          rate: percentageFormat(constants.adminRate, locale),
+          rate: numberFormat(constants.adminRate, locale, {
+            minimumFractionDigits: 2,
+            maximumFractionDigits: 4,
+          }),
         },
       ),
       amount: totals.assessment,