Skip to content

[No Jira] - add browser support section to README#1821

Merged
wjames111 merged 3 commits into
mainfrom
add-browser-support-readme
Jun 4, 2026
Merged

[No Jira] - add browser support section to README#1821
wjames111 merged 3 commits into
mainfrom
add-browser-support-readme

Conversation

@wjames111

@wjames111 wjames111 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Updates readme with current targeted browser support and usage based off of this document.

Testing

  • Go to ...
  • Do ...
  • Check that ...

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Bundle sizes [mpdx-react]

Compared against 2d5c268

No significant changes found

@wjames111 wjames111 force-pushed the add-browser-support-readme branch from d75df0d to c4bfbee Compare June 4, 2026 18:30

@wjames111 wjames111 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-Agent Review Summary

Verdict: APPROVED WITH SUGGESTIONS
Risk: 0/10 (LOW) — documentation-only change
Agents: Architecture, Testing & Quality, Standards (3 of 6, smart-selected)

Findings

  • 0 Critical / 0 High / 0 Important
  • 1 Medium (severity 5.0) — next.mpdx.org URL is not defined in the README's Environments section
  • 4 Suggestions (severity < 5.0) — table layout, date staleness, rounding footnote, (not set) explanation

Verified Facts

  • Next.js version (^15.0.3) matches the "Next.js 15" claim
  • No browserslist in package.json, no .browserslistrc, no overrides in next.config.ts
  • Listed browser targets (Chrome 64+, Edge 79+, Firefox 67+, Safari 12+, Opera 51+) match Next.js 15's documented Browserslist defaults exactly
  • Markdown heading level and table syntax are valid GFM
  • Browser shares sum to 99.8% (rounding-consistent)
  • Date range (Apr 8 – May 5, 2026) is in the past relative to today

No Blockers

This PR can ship as-is. The Medium finding (next.mpdx.org clarification) and Suggestions are polish — address in this PR or follow up later. Suggestions cannot be dismissed via /dismiss because they are below severity 7.0; they are informational only.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
| Browser | Share | | Device | Share |
| :--------- | :---- | :-- | :------ | :---- |
| Chrome | 57.8% | | Desktop | 87.9% |
| (not set) | 21.9% | | Mobile | 11.9% |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] **`(not set)` row is unexplained.**

21.9% is a large bucket without context. A brief parenthetical — e.g., "GA4's bucket for sessions where the browser can't be identified (privacy extensions, bots, embedded webviews)" — would aid readers who aren't familiar with GA terminology.

Flagged by: Architecture Agent + Testing Agent

Comment thread README.md Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Auto-Approval

Risk Level: LOW (0/10)
Verdict: APPROVED_WITH_SUGGESTIONS (suggestions posted, no blockers)

This PR was auto-approved because:

  • The multi-agent AI review determined it is low risk
  • No blocking issues were found
  • All suggestions have been posted as review comments for the developer to consider

If you believe this PR needs human review, dismiss this approval and request a review manually.

@wjames111 wjames111 changed the title docs: add browser support section to README [No Jira] - add browser support section to README Jun 4, 2026
@wjames111 wjames111 self-assigned this Jun 4, 2026
@wjames111 wjames111 added Preview Environment Add this label to create an Amplify Preview On Staging Will be merged to the staging branch by Github Actions labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Preview branch generated at https://add-browser-support-readme.d3dytjb8adxkk5.amplifyapp.com

@wjames111 wjames111 marked this pull request as ready for review June 4, 2026 19:10
@wjames111 wjames111 merged commit 99f7984 into main Jun 4, 2026
56 of 62 checks passed
@wjames111 wjames111 deleted the add-browser-support-readme branch June 4, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant