Skip to content

MPDX-9657 Frontend - Add localized labels for missing staff expense categories and subcategories #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zweatshirt merged 1 commit into from
Jun 5, 2026
Merged

MPDX-9657 Frontend - Add localized labels for missing staff expense categories and subcategories #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/Reports/Shared/Helpers/transformStaffExpenseEnums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
const categoryLabels: Record<StaffExpenseCategoryEnum, string> = {
[StaffExpenseCategoryEnum.Donation]: t('Donation'),
[StaffExpenseCategoryEnum.Transfer]: t('Transfer'),
[StaffExpenseCategoryEnum.AccountTransfer]: t('Account Transfer'),
[StaffExpenseCategoryEnum.StaffExpense]: t('Staff Expense'),
[StaffExpenseCategoryEnum.MinistryReimbursement]: t(
'Ministry Reimbursement',
),
Expand Down Expand Up @@ -132,6 +134,12 @@
[StaffExpensesSubCategoryEnum.StaffAssessment]: t('Staff Assessment'),
[StaffExpensesSubCategoryEnum.OtherAssessment]: t('Other Assessment'),
[StaffExpensesSubCategoryEnum.CreditCardFee]: t('Credit Card Fee'),
[StaffExpensesSubCategoryEnum.AccountTransfer]: t('Account Transfer'),
[StaffExpensesSubCategoryEnum.Registration]: t('Registration'),
[StaffExpensesSubCategoryEnum.Purchase]: t('Purchase'),
[StaffExpensesSubCategoryEnum.SummerMission]: t('Summer Mission'),
[StaffExpensesSubCategoryEnum.Staffcard]: t('StaffCard'),
[StaffExpensesSubCategoryEnum.PaCard]: t('PA Card'),

Check warning on line 142 in src/components/Reports/Shared/Helpers/transformStaffExpenseEnums.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (main)

❌ Getting worse: Large Method 

getLocalizedSubCategory increases from 106 to 112 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
};

return subcategoryLabels[value] ?? t('Unknown Subcategory');
Expand Down
Loading